Add location to RegisterModule

Add support for Location (RTC_FROM_HERE) to ProcessThread::RegisterModule.
This makes a few things a lot clearer when looking at perf trace data:

* What module instances (where they were created) are called
* On what thread
* How frequently
* For how long

ProcessThread will be replaced by TaskQueue moving forward and this is a step towards understanding the behavior of the affected code.

BUG=webrtc:7219
Review-Url: https://codereview.webrtc.org/2729053002
Cr-Commit-Position: refs/heads/master@{#16998}
Committed: https://chromium.googlesource.com/external/webrtc/+/dea489f33e63c518854231fd3a98fabdb2b81563

[tommi, 2017-03-02 18:01:07]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 18:01:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-02 18:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 18:03:24]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/19454)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/23447)

[tommi, 2017-03-02 18:14:51]

Add trace events

[tommi, 2017-03-02 18:19:18]

Update audio_device/BUILD.gn

[tommi, 2017-03-02 18:20:54]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 18:21:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-02 18:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 18:26:13]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14391)

[tommi, 2017-03-02 19:17:01]

Rebase

[tommi, 2017-03-02 19:17:18]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 19:17:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-02 19:22:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 19:22:39]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/6946)

[tommi, 2017-03-03 08:22:17]

Description was changed from

==========
Add location to RegisterModule

BUG=
==========

to

==========
Add location to RegisterModule

BUG=webrtc:7219
==========

[tommi, 2017-03-03 08:25:32]

Description was changed from

==========
Add location to RegisterModule

BUG=webrtc:7219
==========

to

==========
Add support for Location (RTC_FROM_HERE) to ProcessThread::RegisterModule.
This makes a few things a lot clearer when looking at perf trace data:

* What module instances (where they were created) are called
* On what thread
* How frequently
* For how long

ProcessThread will be replaced by TaskQueue moving forward and this is a step
towards understanding the behavior of the affected code.

BUG=webrtc:7219
==========

[tommi, 2017-03-03 08:25:32]

tommi@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2017-03-03 10:06:56]

lgtm

https://codereview.webrtc.org/2729053002/diff/60001/webrtc/modules/utility/so...
File webrtc/modules/utility/source/process_thread_impl.h (right):

https://codereview.webrtc.org/2729053002/diff/60001/webrtc/modules/utility/so...
webrtc/modules/utility/source/process_thread_impl.h:57: Module* const module =
nullptr;
Do you need the default value here? It looks like you initialize module in all
constructors, now that the default constructor is deleted.

[tommi, 2017-03-03 10:35:00]

Don't default initialize |module|

[tommi, 2017-03-03 10:35:40]

Format BUILD.gn

[tommi, 2017-03-03 10:35:46]

https://codereview.webrtc.org/2729053002/diff/60001/webrtc/modules/utility/so...
File webrtc/modules/utility/source/process_thread_impl.h (right):

https://codereview.webrtc.org/2729053002/diff/60001/webrtc/modules/utility/so...
webrtc/modules/utility/source/process_thread_impl.h:57: Module* const module =
nullptr;
On 2017/03/03 10:06:56, kwiberg-webrtc wrote:
> Do you need the default value here? It looks like you initialize module in all
> constructors, now that the default constructor is deleted.

Done.

[tommi, 2017-03-03 10:36:03]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2017-03-03 10:36:04]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2729053002/#ps100001 (title:
"Format BUILD.gn")

[commit-bot: I haz the power, 2017-03-03 10:36:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 11:20:24]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488537363869540,
"parent_rev": "bcb72e786d80e2f306500ed716c42f3a57a74ee6", "commit_rev":
"dea489f33e63c518854231fd3a98fabdb2b81563"}

[commit-bot: I haz the power, 2017-03-03 11:20:27]

Description was changed from

==========
Add support for Location (RTC_FROM_HERE) to ProcessThread::RegisterModule.
This makes a few things a lot clearer when looking at perf trace data:

* What module instances (where they were created) are called
* On what thread
* How frequently
* For how long

ProcessThread will be replaced by TaskQueue moving forward and this is a step
towards understanding the behavior of the affected code.

BUG=webrtc:7219
==========

to

==========
Add support for Location (RTC_FROM_HERE) to ProcessThread::RegisterModule.
This makes a few things a lot clearer when looking at perf trace data:

* What module instances (where they were created) are called
* On what thread
* How frequently
* For how long

ProcessThread will be replaced by TaskQueue moving forward and this is a step
towards understanding the behavior of the affected code.

BUG=webrtc:7219

Review-Url: https://codereview.webrtc.org/2729053002
Cr-Commit-Position: refs/heads/master@{#16998}
Committed:
https://chromium.googlesource.com/external/webrtc/+/dea489f33e63c518854231fd3...
==========

[commit-bot: I haz the power, 2017-03-03 11:20:29]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/dea489f33e63c518854231fd3...