Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2727973004: Adding missing resources to audio_codec_speed_tests. (Closed)

Created:
3 years, 9 months ago by minyue-webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding missing resources to audio_codec_speed_tests. BUG=none Review-Url: https://codereview.webrtc.org/2727973004 Cr-Commit-Position: refs/heads/master@{#19168} Committed: https://chromium.googlesource.com/external/webrtc/+/81f1da3dd0d61ba11540f5d143a73c4d80ab76c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
minyue-webrtc
3 years, 9 months ago (2017-03-03 14:52:35 UTC) #3
minyue-webrtc
PTAL this small CL.
3 years, 9 months ago (2017-03-03 14:53:01 UTC) #4
kjellander_webrtc
lgtm does it make sense to run this test on bots in any way?
3 years, 9 months ago (2017-03-03 19:18:11 UTC) #5
hlundin-webrtc
lgtm
3 years, 9 months ago (2017-03-06 12:35:46 UTC) #6
kjellander_webrtc
still needed? submit?
3 years, 6 months ago (2017-06-21 10:09:06 UTC) #7
minyue-webrtc
Oh, thank you. For some reason it seems to have been forgotten. My bad.
3 years, 6 months ago (2017-06-21 10:14:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2727973004/1
3 years, 6 months ago (2017-06-21 10:15:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/25155)
3 years, 6 months ago (2017-06-21 10:51:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2727973004/1
3 years, 4 months ago (2017-07-27 12:18:46 UTC) #14
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 12:50:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/81f1da3dd0d61ba11540f5d14...

Powered by Google App Engine
This is Rietveld 408576698