Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2727633002: Resolve inconsistent definition of video's webrtc::CodecSpecificInfo. (Closed)

Created:
3 years, 9 months ago by johan
Modified:
3 years, 9 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Resolve inconsistent definition of video's webrtc::CodecSpecificInfo. Following files define the same classes - modules/video_coding/codecs/interface/video_codec_interface.h - modules/video_coding/include/video_codec_interface.h The first one is deprecated. As long as it is not removed, both files should provide consistent class declarations. Otherwise any donwstream project that includes its own codecs could experience memory corruption issues. Before this CL member declarations and ctor definition for webrtc::CodecSpecificInfo diverged between both header files. BUG=webrtc:7280 Review-Url: https://codereview.webrtc.org/2727633002 Cr-Commit-Position: refs/heads/master@{#16944} Committed: https://chromium.googlesource.com/external/webrtc/+/0981cd16f2a598b74300474327ff0485169ce1a8

Patch Set 1 #

Patch Set 2 : Resolve inconsistent definition of video's webrtc::CodecSpecificInfo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -83 lines) Patch
M webrtc/modules/video_coding/codecs/interface/video_codec_interface.h View 1 chunk +1 line, -83 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
johan
3 years, 9 months ago (2017-03-01 12:19:13 UTC) #2
sprang_webrtc
"Nice" find! lgtm
3 years, 9 months ago (2017-03-01 14:04:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2727633002/20001
3 years, 9 months ago (2017-03-01 14:05:43 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 14:32:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0981cd16f2a598b7430047432...

Powered by Google App Engine
This is Rietveld 408576698