Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2727503003: Disable flaky test while working on improvement. (Closed)

Created:
3 years, 9 months ago by sprang_webrtc
Modified:
3 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable flaky test while working on improvement. WebRtcVideoEngine2Test.RecreatesEncoderOnContentTypeChange is flaky. Disable it temporarily, while working on improvement. TBR=pthatcher@webrtc.org BUG=webrtc:7275 Review-Url: https://codereview.webrtc.org/2727503003 Cr-Commit-Position: refs/heads/master@{#16937} Committed: https://chromium.googlesource.com/external/webrtc/+/f31969a584bcafe9406c214a9d4c3afb49d19650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2727503003/1
3 years, 9 months ago (2017-03-01 09:45:36 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-01 09:45:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2727503003/1
3 years, 9 months ago (2017-03-01 09:46:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/f31969a584bcafe9406c214a9d4c3afb49d19650
3 years, 9 months ago (2017-03-01 10:27:38 UTC) #11
tommi
3 years, 9 months ago (2017-03-01 10:45:48 UTC) #12
Message was sent while issue was closed.
On 2017/03/01 10:27:38, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/webrtc/+/f31969a584bcafe9406c214a9...

when disabling tests like this it can be helpful to add a comment that explains
why the test is disabled with a link to the bug so that readers can check in on
the progress

Powered by Google App Engine
This is Rietveld 408576698