Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2727273002: Fix memory leaks in Windows core audio (Closed)

Created:
3 years, 9 months ago by jens.nielsen
Modified:
3 years, 9 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix memory leaks in Windows core audio BUG=webrtc:7270 Review-Url: https://codereview.webrtc.org/2727273002 Cr-Commit-Position: refs/heads/master@{#17056} Committed: https://chromium.googlesource.com/external/webrtc/+/5571ee94653536596f7c04fb1e20eb050b4ae385

Patch Set 1 #

Total comments: 3

Patch Set 2 : Replace WEBRTC_TRACE with LOG macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M webrtc/modules/audio_device/win/audio_device_core_win.cc View 1 5 chunks +33 lines, -22 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
jens.nielsen
Hi Here's a couple of memory leak fixes. I don't think it's super easy to ...
3 years, 9 months ago (2017-03-02 14:56:28 UTC) #2
henrika_webrtc
I can only give some short generic feedback this week. This class is super old ...
3 years, 9 months ago (2017-03-02 15:07:57 UTC) #3
jens.nielsen
On 2017/03/02 15:07:57, henrika_webrtc wrote: > I can only give some short generic feedback this ...
3 years, 9 months ago (2017-03-02 15:42:20 UTC) #4
henrika_webrtc
Thanks. Might be slow with feedback. But appreciate your work.
3 years, 9 months ago (2017-03-02 17:13:05 UTC) #5
henrika_webrtc
Your patch seems to resolve the issue. As mentioned, the state of this code is ...
3 years, 9 months ago (2017-03-06 08:56:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2727273002/20001
3 years, 9 months ago (2017-03-06 10:22:19 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 10:24:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/5571ee94653536596f7c04fb1...

Powered by Google App Engine
This is Rietveld 408576698