Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2726983005: Revert of BlankDetectorDesktopCapturerWrapper to detect a blank DesktopFrame (Closed)

Created:
3 years, 9 months ago by perkj_webrtc
Modified:
3 years, 9 months ago
Reviewers:
Sergey Ulanov, Hzj_jie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Jamie
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of BlankDetectorDesktopCapturerWrapper to detect a blank DesktopFrame (patchset #7 id:180001 of https://codereview.webrtc.org/2709523003/ ) Reason for revert: Misses deps for RTC_HISTOGRAM in Chrome. email sent separately. Also see https://codereview.chromium.org/2725143004/. Original issue's description: > BlankDetectorDesktopCapturerWrapper to detect a blank DesktopFrame > > DXGI capturer highly depends on video adapter and its driver, as well as Windows > itself. I recently found it cannot work on my virtualbox instance any more, > which indicates it may not work well on some specific systems. What worse is, > the APIs do not return a failure in such case. > > So this change adds a BlankDetectorDesktopCapturerWrapper, which samples several > pixels in the frame returned by a DesktopCapturer implementation. If all the > pixels selected are blank, this wrapper returns a failure. A typical usage is to > combine BlankDetectorDesktopCapturerWrapper with FallbackDesktopCapturerWrapper, > and use GDI capturer in case of failure. > > Usually less than 500 pixels are checked, so the > BlankDetectorDesktopCapturerWrapper should not impact the capturer performance. > > This change is expected to resolve bug 682112 in another dimension. > > BUG=682112 > > Review-Url: https://codereview.webrtc.org/2709523003 > Cr-Commit-Position: refs/heads/master@{#16984} > Committed: https://chromium.googlesource.com/external/webrtc/+/c4e9d210b3516c7b2faa32f24409a2e626599255 TBR=sergeyu@chromium.org,zijiehe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=682112 Review-Url: https://codereview.webrtc.org/2726983005 Cr-Commit-Position: refs/heads/master@{#16993} Committed: https://chromium.googlesource.com/external/webrtc/+/528a834ef079e0821c76b6bb256ddc48602320ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -379 lines) Patch
M webrtc/modules/desktop_capture/BUILD.gn View 6 chunks +21 lines, -6 lines 0 comments Download
D webrtc/modules/desktop_capture/blank_detector_desktop_capturer_wrapper.h View 1 chunk +0 lines, -74 lines 0 comments Download
D webrtc/modules/desktop_capture/blank_detector_desktop_capturer_wrapper.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D webrtc/modules/desktop_capture/blank_detector_desktop_capturer_wrapper_unittest.cc View 1 chunk +0 lines, -163 lines 0 comments Download
M webrtc/modules/desktop_capture/rgba_color.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_win.cc View 1 chunk +4 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
perkj_webrtc
Created Revert of BlankDetectorDesktopCapturerWrapper to detect a blank DesktopFrame
3 years, 9 months ago (2017-03-03 08:01:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2726983005/1
3 years, 9 months ago (2017-03-03 08:01:42 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 08:01:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/528a834ef079e0821c76b6bb2...

Powered by Google App Engine
This is Rietveld 408576698