Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2726633004: Fixing "control reaches end of non-void function" compile warning. (Closed)

Created:
3 years, 9 months ago by Taylor Brandstetter
Modified:
3 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing "control reaches end of non-void function" compile warning. Warning is benign in this case, and the returns won't ever actually be hit. BUG=chromium:697060 Review-Url: https://codereview.webrtc.org/2726633004 Cr-Commit-Position: refs/heads/master@{#16926} Committed: https://chromium.googlesource.com/external/webrtc/+/3c8771e929b8a4675c4ca641157be04398aca274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M webrtc/api/mediatypes.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Taylor Brandstetter
3 years, 9 months ago (2017-02-28 21:58:15 UTC) #3
pthatcher1
lgtm
3 years, 9 months ago (2017-03-01 01:54:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2726633004/1
3 years, 9 months ago (2017-03-01 01:55:22 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 02:30:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/3c8771e929b8a4675c4ca6411...

Powered by Google App Engine
This is Rietveld 408576698