Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2726563002: Make hbos and hta rtcstats* OWNERS of webrtc/pc, not webrtc/api. (Closed)

Created:
3 years, 9 months ago by hbos
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make hbos and hta rtcstats* OWNERS of webrtc/pc, not webrtc/api. We were already OWNERS of these files, but when these files were moved from webrtc/api/ to webrtc/pc/ and a new OWNERS file created our ownership was accidentally not moved. Becoming per-file=rtcstats* OWNER of webrtc/pc/ which includes: rtcstats_integrationtest.cc rtcstatscollector.cc rtcstatscollector.h rtcstatscollector_unittest.cc Dropping ownership of webrtc/api/ which no longer includes any rtcstats* files. Already OWNER of all of webrtc/api/stats/ which includes: rtcstats.h rtcstats_objects.h rtcstatscollectorcallback.h rtcstatsreport.h Already OWNER of all of webrtc/stats/ which includes: rtcstats.cc rtcstats_objects.cc rtcstats_unittest.cc rtcstatsreport.cc rtcstatsreport_unittest.cc BUG=webrtc:7060 TBR=hta@webrtc.org, deadbeef@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2726563002 Cr-Commit-Position: refs/heads/master@{#16906} Committed: https://chromium.googlesource.com/external/webrtc/+/7562fc8adb09aa2fe1a8ca10b1ebf6b3e8beac07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/api/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/pc/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2726563002/20001
3 years, 9 months ago (2017-02-28 14:44:51 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 14:46:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/7562fc8adb09aa2fe1a8ca10b...

Powered by Google App Engine
This is Rietveld 408576698