Removes usage audio_device_test_api

Removes usage audio_device_test_api.

These tests are very old and come from a time when we tested each method in the
ADM as if the ADM should function as a standalone component.
Several tests are already disabled and we test combinations of APIs that are no
longer valid (since the ADM is now used in a more fixed way in VoE).
The tests does not verify media (we have other tests under
voice_engine/test/auto_test) which starts media and verifies that it works OK.
There are also a a more extensive set of ADM tests for Android and iOS.
You could also say that these tests tests the most "hardware related parts of
the ADM", but not those that we expose via the VoEHardware API.
Hence, not much value to maintain them imo.

NOTRY=TRUE
BUG=webrtc:7250
Review-Url: https://codereview.webrtc.org/2726433003
Cr-Commit-Position: refs/heads/master@{#19522}
Committed: https://chromium.googlesource.com/external/webrtc/+/5a0c4ed21977d18a5d80179e541d607834ea79a0

[henrika_webrtc, 2017-02-28 09:41:11]

Description was changed from

==========
Removes usage audio_device_test_api

format nit


Removing unused audio device tests

BUG=
==========

to

==========
Removes usage audio_device_test_api.

These tests are very old and come from a time when we tested each method in the
ADM as if the ADM should function as a standalone component.
Several tests are already disabled and we test combinations of APIs that are no
longer valid (since the ADM is now used in a more fixed way in VoE).
The tests does not verify media (we have other tests under
voice_engine/test/auto_test) which starts media and verifies that it works OK.
There are also a a more extensive set of ADM tests for Android and iOS.
You could also say that these tests tests the most "hardware related parts of
the ADM", but not those that we expose via the VoEHardware API.
Hence, not much value to maintain them imo.

BUG=webrtc:7250
==========

[henrika_webrtc, 2017-02-28 09:41:11]

henrika@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[henrika_webrtc, 2017-02-28 09:41:42]

The CQ bit was checked by henrika@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 09:41:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 10:02:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 10:02:03]

Dry run: This issue passed the CQ dry run.

[henrika_webrtc, 2017-03-02 08:51:57]

I will wait with this CL until we have better test coverage for the ADM.
No need to review as is.

[henrika_webrtc, 2017-08-25 13:49:01]

As discussed. We now have a new set of ADM tests which tests more basic ADM
functionality
and that is more useful than maintaining these very old and detailed tests.

PTAL

[henrika_webrtc, 2017-08-25 13:49:23]

The CQ bit was checked by henrika@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-25 13:49:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[the sun, 2017-08-25 14:07:16]

lgtm

[henrika_webrtc, 2017-08-25 14:44:31]

The CQ bit was unchecked by henrika@webrtc.org

[henrika_webrtc, 2017-08-25 14:44:45]

Description was changed from

==========
Removes usage audio_device_test_api.

These tests are very old and come from a time when we tested each method in the
ADM as if the ADM should function as a standalone component.
Several tests are already disabled and we test combinations of APIs that are no
longer valid (since the ADM is now used in a more fixed way in VoE).
The tests does not verify media (we have other tests under
voice_engine/test/auto_test) which starts media and verifies that it works OK.
There are also a a more extensive set of ADM tests for Android and iOS.
You could also say that these tests tests the most "hardware related parts of
the ADM", but not those that we expose via the VoEHardware API.
Hence, not much value to maintain them imo.

BUG=webrtc:7250
==========

to

==========
Removes usage audio_device_test_api.

These tests are very old and come from a time when we tested each method in the
ADM as if the ADM should function as a standalone component.
Several tests are already disabled and we test combinations of APIs that are no
longer valid (since the ADM is now used in a more fixed way in VoE).
The tests does not verify media (we have other tests under
voice_engine/test/auto_test) which starts media and verifies that it works OK.
There are also a a more extensive set of ADM tests for Android and iOS.
You could also say that these tests tests the most "hardware related parts of
the ADM", but not those that we expose via the VoEHardware API.
Hence, not much value to maintain them imo.

NOTRY=TRUE
BUG=webrtc:7250
==========

[henrika_webrtc, 2017-08-25 14:44:50]

The CQ bit was checked by henrika@webrtc.org

[commit-bot: I haz the power, 2017-08-25 14:45:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-25 14:47:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503672290001650,
"parent_rev": "99b63455b758f508699125d383032141078361c0", "commit_rev":
"5a0c4ed21977d18a5d80179e541d607834ea79a0"}

[commit-bot: I haz the power, 2017-08-25 14:47:36]

Description was changed from

==========
Removes usage audio_device_test_api.

These tests are very old and come from a time when we tested each method in the
ADM as if the ADM should function as a standalone component.
Several tests are already disabled and we test combinations of APIs that are no
longer valid (since the ADM is now used in a more fixed way in VoE).
The tests does not verify media (we have other tests under
voice_engine/test/auto_test) which starts media and verifies that it works OK.
There are also a a more extensive set of ADM tests for Android and iOS.
You could also say that these tests tests the most "hardware related parts of
the ADM", but not those that we expose via the VoEHardware API.
Hence, not much value to maintain them imo.

NOTRY=TRUE
BUG=webrtc:7250
==========

to

==========
Removes usage audio_device_test_api.

These tests are very old and come from a time when we tested each method in the
ADM as if the ADM should function as a standalone component.
Several tests are already disabled and we test combinations of APIs that are no
longer valid (since the ADM is now used in a more fixed way in VoE).
The tests does not verify media (we have other tests under
voice_engine/test/auto_test) which starts media and verifies that it works OK.
There are also a a more extensive set of ADM tests for Android and iOS.
You could also say that these tests tests the most "hardware related parts of
the ADM", but not those that we expose via the VoEHardware API.
Hence, not much value to maintain them imo.

NOTRY=TRUE
BUG=webrtc:7250

Review-Url: https://codereview.webrtc.org/2726433003
Cr-Commit-Position: refs/heads/master@{#19522}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5a0c4ed21977d18a5d80179e5...
==========

[commit-bot: I haz the power, 2017-08-25 14:47:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/5a0c4ed21977d18a5d80179e5...

[kjellander_webrtc, 2017-08-25 15:29:22]

kjellander@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-08-25 15:29:22]

Way to go. Deleting dead code is super.
Thanks for the thorough motivation in the description as well!