Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2726263004: Fixing race between CallbackCanceled and CancelCallback in AsyncInvoker. (Closed)

Created:
3 years, 9 months ago by Taylor Brandstetter
Modified:
3 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing race between CallbackCanceled and CancelCallback in AsyncInvoker. Pointer was already protected by a critical section in two places but not the third. Added thread annotations to prevent this from happening in the future. BUG=None Review-Url: https://codereview.webrtc.org/2726263004 Cr-Commit-Position: refs/heads/master@{#17017} Committed: https://chromium.googlesource.com/external/webrtc/+/b85a88853a651a248078194089e9d5563a41350c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M webrtc/base/asyncinvoker-inl.h View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
3 years, 9 months ago (2017-03-03 06:07:49 UTC) #2
pthatcher1
lgtm
3 years, 9 months ago (2017-03-03 06:40:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2726263004/1
3 years, 9 months ago (2017-03-03 18:02:20 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 18:33:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b85a88853a651a24807819408...

Powered by Google App Engine
This is Rietveld 408576698