Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2725553002: Fixed cpu time unittest to be less flaky (Closed)

Created:
3 years, 9 months ago by ilnik
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed cpu time unittest to be less flaky BUG=webrtc:7095 Review-Url: https://codereview.webrtc.org/2725553002 Cr-Commit-Position: refs/heads/master@{#16897} Committed: https://chromium.googlesource.com/external/webrtc/+/78f2d21e74f09301aa70e7055ed9c4f373386098

Patch Set 1 #

Patch Set 2 : Fixing CE on WIN #

Total comments: 2

Patch Set 3 : Implemented Deadbeef@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -57 lines) Patch
M webrtc/base/cpu_time_unittest.cc View 1 2 3 chunks +33 lines, -57 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ilnik
3 years, 9 months ago (2017-02-28 09:32:38 UTC) #2
Taylor Brandstetter
lgtm https://codereview.webrtc.org/2725553002/diff/20001/webrtc/base/cpu_time_unittest.cc File webrtc/base/cpu_time_unittest.cc (right): https://codereview.webrtc.org/2725553002/diff/20001/webrtc/base/cpu_time_unittest.cc#newcode71 webrtc/base/cpu_time_unittest.cc:71: webrtc::SleepMs(kProcessingTimeMillisecs); nit: Checking the time before and after ...
3 years, 9 months ago (2017-02-28 09:46:39 UTC) #3
ilnik
https://codereview.webrtc.org/2725553002/diff/20001/webrtc/base/cpu_time_unittest.cc File webrtc/base/cpu_time_unittest.cc (right): https://codereview.webrtc.org/2725553002/diff/20001/webrtc/base/cpu_time_unittest.cc#newcode71 webrtc/base/cpu_time_unittest.cc:71: webrtc::SleepMs(kProcessingTimeMillisecs); On 2017/02/28 09:46:39, Taylor Brandstetter wrote: > nit: ...
3 years, 9 months ago (2017-02-28 09:53:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2725553002/40001
3 years, 9 months ago (2017-02-28 09:54:47 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 10:24:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/78f2d21e74f09301aa70e7055...

Powered by Google App Engine
This is Rietveld 408576698