Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 2725233002: Adding YouCompleteMe config for WebRTC. (Closed)

Created:
3 years, 9 months ago by Taylor Brandstetter
Modified:
3 years, 9 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding YouCompleteMe config for WebRTC. Mostly just copied from Chromium, replacing instances of "chromium" with "webrtc". BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2725233002 Cr-Commit-Position: refs/heads/master@{#16988} Committed: https://chromium.googlesource.com/external/webrtc/+/dc9200e314a3ca66a26f64eb1870380e715250df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -0 lines) Patch
A tools-webrtc/vim/webrtc.ycm_extra_conf.py View 1 chunk +357 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Taylor Brandstetter
3 years, 9 months ago (2017-03-02 23:36:51 UTC) #2
kjellander_webrtc
lgtm it would have been nice to have the pristine file in PS#1 and then ...
3 years, 9 months ago (2017-03-03 04:11:46 UTC) #3
Taylor Brandstetter
On 2017/03/03 04:11:46, kjellander_webrtc wrote: > lgtm > > it would have been nice to ...
3 years, 9 months ago (2017-03-03 05:46:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2725233002/1
3 years, 9 months ago (2017-03-03 05:46:24 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 05:48:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/dc9200e314a3ca66a26f64eb1...

Powered by Google App Engine
This is Rietveld 408576698