Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 2724963005: Fix perf_setup.sh for zsh. (Closed)

Created:
3 years, 9 months ago by sakal
Modified:
3 years, 9 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix perf_setup.sh for zsh. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2724963005 Cr-Commit-Position: refs/heads/master@{#16994} Committed: https://chromium.googlesource.com/external/webrtc/+/e7b8c3759b6865e1dec3bef84a6d82362ea9d855

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M tools-webrtc/android/profiling/perf_setup.sh View 3 chunks +10 lines, -3 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
sakal
PTAL
3 years, 9 months ago (2017-03-02 16:20:25 UTC) #2
henrika_webrtc
Thanks for fixing! https://codereview.webrtc.org/2724963005/diff/1/tools-webrtc/android/profiling/perf_setup.sh File tools-webrtc/android/profiling/perf_setup.sh (right): https://codereview.webrtc.org/2724963005/diff/1/tools-webrtc/android/profiling/perf_setup.sh#newcode37 tools-webrtc/android/profiling/perf_setup.sh:37: SCRIPT_PATH="${(%):-%N}" I can't say how that ...
3 years, 9 months ago (2017-03-02 17:20:57 UTC) #3
henrika_webrtc
lgtm
3 years, 9 months ago (2017-03-02 17:21:06 UTC) #4
henrika_webrtc
PS, I remember that I've seen this in another script. Looks simpler but not sure ...
3 years, 9 months ago (2017-03-02 17:22:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2724963005/1
3 years, 9 months ago (2017-03-03 08:01:56 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 08:04:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e7b8c3759b6865e1dec3bef84...

Powered by Google App Engine
This is Rietveld 408576698