Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2724443003: Re-enable disabled test and upgrade avformatmappertests to OCMock 3 syntax. (Closed)

Created:
3 years, 9 months ago by daniela-webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-enable disabled test and upgrade avformatmappertests to OCMock 3 syntax. BUG=webrtc:7137 Review-Url: https://codereview.webrtc.org/2724443003 Cr-Commit-Position: refs/heads/master@{#16917} Committed: https://chromium.googlesource.com/external/webrtc/+/907abd8414e6d2af97efa424760a4b9878f0f1be

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -34 lines) Patch
M webrtc/sdk/objc/Framework/UnitTests/avformatmappertests.mm View 1 7 chunks +36 lines, -34 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
daniela-webrtc
3 years, 9 months ago (2017-02-28 08:46:18 UTC) #2
kthelgason
lgtm!
3 years, 9 months ago (2017-02-28 09:41:10 UTC) #3
magjed_webrtc
lgtm https://codereview.webrtc.org/2724443003/diff/1/webrtc/sdk/objc/Framework/UnitTests/avformatmappertests.mm File webrtc/sdk/objc/Framework/UnitTests/avformatmappertests.mm (right): https://codereview.webrtc.org/2724443003/diff/1/webrtc/sdk/objc/Framework/UnitTests/avformatmappertests.mm#newcode236 webrtc/sdk/objc/Framework/UnitTests/avformatmappertests.mm:236: // Without it, stubed exceptions are being re-raised ...
3 years, 9 months ago (2017-02-28 16:03:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2724443003/20001
3 years, 9 months ago (2017-02-28 16:30:34 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 17:14:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/907abd8414e6d2af97efa4247...

Powered by Google App Engine
This is Rietveld 408576698