Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2724153003:
vp8_impl.cc: Apply boost on golden frames. (Closed)
|
Created:
3 years, 9 months ago by åsapersson Modified:
3 years, 9 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
Descriptionvp8_impl.cc: Apply boost on golden frames (under field trial).
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2724153003
Cr-Commit-Position: refs/heads/master@{#17202}
Committed: https://chromium.googlesource.com/external/webrtc/+/d0d08b1568d00b344fb11d772a4a9604c53cadba
Patch Set 1 #
Total comments: 2
Patch Set 2 : address comment #
Messages
Total messages: 26 (18 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== vp8_impl.cc: Apply boost on golden frames. The gf boost percentage (affecting the increase target size of golden frames) is set to 50. BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Apply boost on golden frames (under field trial). The gf boost percentage (controlling the increase target size of golden frames) is set to 50. BUG=webrtc:6634 ==========
Patchset #1 (id:40001) has been deleted
asapersson@webrtc.org changed reviewers: + brandtr@webrtc.org, marpan@webrtc.org
Description was changed from ========== vp8_impl.cc: Apply boost on golden frames (under field trial). The gf boost percentage (controlling the increase target size of golden frames) is set to 50. BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Apply boost on golden frames (under field trial). The gf boost percentage (controlling the increase in target size of golden frames) is set to 50. BUG=webrtc:6634 ==========
Patchset #1 (id:60001) has been deleted
marpan@google.com changed reviewers: + marpan@google.com
lgtm
https://codereview.webrtc.org/2724153003/diff/80001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/2724153003/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:640: const int kGfBoostPercent = 50; Maybe we should send in this value as part of the field trial string?
Description was changed from ========== vp8_impl.cc: Apply boost on golden frames (under field trial). The gf boost percentage (controlling the increase in target size of golden frames) is set to 50. BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Apply boost on golden frames (under field trial). BUG=webrtc:6634 ==========
https://codereview.webrtc.org/2724153003/diff/80001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/2724153003/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:640: const int kGfBoostPercent = 50; On 2017/03/10 08:21:31, brandtr wrote: > Maybe we should send in this value as part of the field trial string? Sounds good. Done.
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
asapersson@webrtc.org changed reviewers: + sprang@webrtc.org
lgtm
lgtm
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from marpan@google.com Link to the patchset: https://codereview.webrtc.org/2724153003/#ps100001 (title: "address comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489397940863390,
"parent_rev": "c6192a9e3207cd3c2815939c9c6a68cbf97905de", "commit_rev":
"d0d08b1568d00b344fb11d772a4a9604c53cadba"}
Message was sent while issue was closed.
Description was changed from ========== vp8_impl.cc: Apply boost on golden frames (under field trial). BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Apply boost on golden frames (under field trial). BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2724153003 Cr-Commit-Position: refs/heads/master@{#17202} Committed: https://chromium.googlesource.com/external/webrtc/+/d0d08b1568d00b344fb11d772... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as https://chromium.googlesource.com/external/webrtc/+/d0d08b1568d00b344fb11d772... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
