Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2723983002: Switch temporal layer impl used for screenshare upper simulcast stream. (Closed)

Created:
3 years, 9 months ago by sprang_webrtc
Modified:
3 years, 9 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Switch temporal layer impl used for screenshare upper simulcast stream. Use default temporal layers instead of the RealtimeTemporalLayers one. When using low fps, having a single stream with much higher bitrate than the lower simulcast stream causes poor rampup behavior. Tested manually. BUG=webrtc:4172 Review-Url: https://codereview.webrtc.org/2723983002 Cr-Commit-Position: refs/heads/master@{#16934} Committed: https://chromium.googlesource.com/external/webrtc/+/5271ea6571c1e6d0c38f13636181f800b58d7494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
sprang_webrtc
3 years, 9 months ago (2017-03-01 08:39:48 UTC) #3
åsapersson
lgtm
3 years, 9 months ago (2017-03-01 09:52:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2723983002/1
3 years, 9 months ago (2017-03-01 09:56:00 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 09:58:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5271ea6571c1e6d0c38f13636...

Powered by Google App Engine
This is Rietveld 408576698