Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2723893004:
Opus: Let the decoder interpret 2-byte payloads as DTX/CNG packets (Closed)
|
Created:
3 years, 9 months ago by hlundin-webrtc Modified:
3 years, 9 months ago CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionOpus: Let the decoder interpret 2-byte payloads as DTX/CNG packets
This CL matches the work done in
https://codereview.webrtc.org/2693453003.
BUG=webrtc:7272
TBR=minyue@webrtc.org
Review-Url: https://codereview.webrtc.org/2723893004
Cr-Commit-Position: refs/heads/master@{#16930}
Committed: https://chromium.googlesource.com/external/webrtc/+/deaf6fb071e68a242db342d61a11220edd2bb546
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
henrik.lundin@webrtc.org changed reviewers: + flim@webrtc.org, minyue@webrtc.org
PTAL when you get a chance. I'm TBR:ing this given the tight deadline for the cut.
The CQ bit was checked by henrik.lundin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Opus: Let the decoder interpret 2-byte payloads as DTX/CNG packets This CL matches the work done in https://codereview.webrtc.org/2693453003. BUG=webrtc:7272 TRB=minyue@webrtc.org, flim@webrtc.org ========== to ========== Opus: Let the decoder interpret 2-byte payloads as DTX/CNG packets This CL matches the work done in https://codereview.webrtc.org/2693453003. BUG=webrtc:7272 TRB=minyue@webrtc.org ==========
The CQ bit was checked by henrik.lundin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Opus: Let the decoder interpret 2-byte payloads as DTX/CNG packets This CL matches the work done in https://codereview.webrtc.org/2693453003. BUG=webrtc:7272 TRB=minyue@webrtc.org ========== to ========== Opus: Let the decoder interpret 2-byte payloads as DTX/CNG packets This CL matches the work done in https://codereview.webrtc.org/2693453003. BUG=webrtc:7272 TBR=minyue@webrtc.org ==========
The CQ bit was checked by henrik.lundin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/11552)
The CQ bit was checked by henrik.lundin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488358021649120, "parent_rev":
"e985b3fe49738b78d9b19fad8d24eae81628c181", "commit_rev":
"deaf6fb071e68a242db342d61a11220edd2bb546"}
Message was sent while issue was closed.
Description was changed from ========== Opus: Let the decoder interpret 2-byte payloads as DTX/CNG packets This CL matches the work done in https://codereview.webrtc.org/2693453003. BUG=webrtc:7272 TBR=minyue@webrtc.org ========== to ========== Opus: Let the decoder interpret 2-byte payloads as DTX/CNG packets This CL matches the work done in https://codereview.webrtc.org/2693453003. BUG=webrtc:7272 TBR=minyue@webrtc.org Review-Url: https://codereview.webrtc.org/2723893004 Cr-Commit-Position: refs/heads/master@{#16930} Committed: https://chromium.googlesource.com/external/webrtc/+/deaf6fb071e68a242db342d61... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/deaf6fb071e68a242db342d61...
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
