Fix cyclic deps: rent_a_codec<->audio_coding and rent_a_codec<->neteq

Fix cyclic deps: rent_a_codec<->audio_coding and rent_a_codec<->neteq

In short, what I did was to

  * Remove acm_common_defs.h (the stuff in it was used only by
    acm_codec_database.cc).

  * Move audio_coding_module_typedefs.h to a new build target.

  * Move the NetEqDecoder enum (and the associated
    NetEqDecoderToSdpAudioFormat function) to a new file in a new
    build target.

BUG=webrtc:7243, webrtc:7244
Review-Url: https://codereview.webrtc.org/2723253005
Cr-Commit-Position: refs/heads/master@{#17005}
Committed: https://chromium.googlesource.com/external/webrtc/+/65cb70d939af8f9b6b8b1af9109dd7385af79f0c

[kwiberg-webrtc, 2017-03-02 04:00:47]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 04:00:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-02 04:03:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 04:03:38]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm/builds/6351)

[kwiberg-webrtc, 2017-03-02 11:56:31]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 11:56:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-03-02 11:56:50]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-03-02 12:23:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 12:23:52]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-03-02 12:27:32]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, kjellander@webrtc.org

[kjellander_webrtc, 2017-03-02 17:37:00]

BUILD.gn: lgtm

re-run the Chromium trybots (patch failure)

[kwiberg-webrtc, 2017-03-02 18:46:24]

On 2017/03/02 17:37:00, kjellander_webrtc wrote:
> BUILD.gn: lgtm
> 
> re-run the Chromium trybots (patch failure)

I already did, and rebased, but they failed again. IIRC they don't like CLs that
add and remove files?

[kjellander_webrtc, 2017-03-02 23:31:32]

On 2017/03/02 18:46:24, kwiberg-webrtc wrote:
> On 2017/03/02 17:37:00, kjellander_webrtc wrote:
> > BUILD.gn: lgtm
> > 
> > re-run the Chromium trybots (patch failure)
> 
> I already did, and rebased, but they failed again. IIRC they don't like CLs
that
> add and remove files?

Ah, sorry. I didn't see the deleted file earlier. You're right, this is a known
issue but it will get fixed by us moving to Gerrit.

[hlundin-webrtc, 2017-03-03 13:29:38]

lgtm

[kwiberg-webrtc, 2017-03-03 13:37:53]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-03-03 13:38:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 14:16:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488548273533780,
"parent_rev": "154a7bb877abefada22afe28b0a755cf621e8d9e", "commit_rev":
"65cb70d939af8f9b6b8b1af9109dd7385af79f0c"}

[commit-bot: I haz the power, 2017-03-03 14:16:31]

Description was changed from

==========
Fix cyclic deps: rent_a_codec<->audio_coding and rent_a_codec<->neteq

In short, what I did was to

  * Remove acm_common_defs.h (the stuff in it was used only by
    acm_codec_database.cc).

  * Move audio_coding_module_typedefs.h to a new build target.

  * Move the NetEqDecoder enum (and the associated
    NetEqDecoderToSdpAudioFormat function) to a new file in a new
    build target.

BUG=webrtc:7243, webrtc:7244
==========

to

==========
Fix cyclic deps: rent_a_codec<->audio_coding and rent_a_codec<->neteq

In short, what I did was to

  * Remove acm_common_defs.h (the stuff in it was used only by
    acm_codec_database.cc).

  * Move audio_coding_module_typedefs.h to a new build target.

  * Move the NetEqDecoder enum (and the associated
    NetEqDecoderToSdpAudioFormat function) to a new file in a new
    build target.

BUG=webrtc:7243, webrtc:7244

Review-Url: https://codereview.webrtc.org/2723253005
Cr-Commit-Position: refs/heads/master@{#17005}
Committed:
https://chromium.googlesource.com/external/webrtc/+/65cb70d939af8f9b6b8b1af91...
==========

[commit-bot: I haz the power, 2017-03-03 14:16:32]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/65cb70d939af8f9b6b8b1af91...