Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2722613002: Simplify webrtc::voe::MonitorModule and remove the .cc file. (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Simplify webrtc::voe::MonitorModule and remove the .cc file. The class basically implements a timer and can be replaced with a PostDelayedTask call down the line. BUG=none Review-Url: https://codereview.webrtc.org/2722613002 Cr-Commit-Position: refs/heads/master@{#16891} Committed: https://chromium.googlesource.com/external/webrtc/+/b1175bb101a3c9682db929ae476732f4c43fb9a4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -117 lines) Patch
M webrtc/voice_engine/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/monitor_module.h View 1 1 chunk +17 lines, -34 lines 0 comments Download
D webrtc/voice_engine/monitor_module.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 4 chunks +4 lines, -6 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 1 4 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
tommi
3 years, 9 months ago (2017-02-27 18:19:48 UTC) #2
henrika_webrtc
Nice cleanup. LGTM % the fact that it might even be possible to remove the ...
3 years, 9 months ago (2017-02-28 08:24:21 UTC) #7
tommi
Add TODO
3 years, 9 months ago (2017-02-28 08:38:39 UTC) #8
tommi
https://codereview.webrtc.org/2722613002/diff/1/webrtc/voice_engine/monitor_module.h File webrtc/voice_engine/monitor_module.h (right): https://codereview.webrtc.org/2722613002/diff/1/webrtc/voice_engine/monitor_module.h#newcode30 webrtc/voice_engine/monitor_module.h:30: void Process() override { observer_->OnPeriodicProcess(); } On 2017/02/28 08:24:21, ...
3 years, 9 months ago (2017-02-28 08:38:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2722613002/20001
3 years, 9 months ago (2017-02-28 08:39:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, no build URL)
3 years, 9 months ago (2017-02-28 08:56:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2722613002/20001
3 years, 9 months ago (2017-02-28 08:59:55 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/b1175bb101a3c9682db929ae476732f4c43fb9a4
3 years, 9 months ago (2017-02-28 09:16:53 UTC) #19
the sun
3 years, 9 months ago (2017-02-28 10:11:19 UTC) #20
Message was sent while issue was closed.
On 2017/02/28 08:38:43, tommi (webrtc) wrote:
>
https://codereview.webrtc.org/2722613002/diff/1/webrtc/voice_engine/monitor_m...
> File webrtc/voice_engine/monitor_module.h (right):
> 
>
https://codereview.webrtc.org/2722613002/diff/1/webrtc/voice_engine/monitor_m...
> webrtc/voice_engine/monitor_module.h:30: void Process() override {
> observer_->OnPeriodicProcess(); }
> On 2017/02/28 08:24:21, henrika_webrtc wrote:
> > To me it looks like TransmitMixer::OnPeridodicProcess contains e.g
> > VE_TYPING_NOISE_OFF_WARNING and VE_SATURATION_WARNING. Instead of improving
> this
> > class even more (by using delayed PostTask), it might be worth considering
if
> it
> > can be removed completely. Henrik L should know if any of the callbacks are
> used
> > today.
> 
> Good point... I looked around for VE_SATURATION_WARNING and all I can find is
> this:
> 
>     printf("  SATURATION WARNING \n");
> 
> in voe_cmd_test.cc
> 
> It would be good to delete this if it's not being used.  We'd get rid of one
> lock inside of TransmitMixer::ProcessAudio.  Added a TODO for now in this
file,
> with details.

Yes, voe_cmd_test is reaching EOL with the removal of the legacy APIs.

Thanks for the cleanup Tommi!

Powered by Google App Engine
This is Rietveld 408576698