Adding metrics to AEC3

Adding metrics to AEC3.

This CL adds metrics reporting to AEC3.

BUG=webrtc:6018
Review-Url: https://codereview.webrtc.org/2722453002
Cr-Commit-Position: refs/heads/master@{#16929}
Committed: https://chromium.googlesource.com/external/webrtc/+/e985b3fe49738b78d9b19fad8d24eae81628c181

[peah-webrtc, 2017-02-28 01:24:18]

Description was changed from

==========
Adding echo remover metrics

BUG=
==========

to

==========
Adding metrics to AEC3.

This CL adds metrics reporting to AEC3.

BUG=webrtc:6018
==========

[peah-webrtc, 2017-02-28 01:24:28]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2017-02-28 01:24:45]

Patchset #1 (id:20001) has been deleted

[peah-webrtc, 2017-02-28 01:26:16]

Patchset #1 (id:40001) has been deleted

[peah-webrtc, 2017-02-28 01:26:52]

peah@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[peah-webrtc, 2017-02-28 01:26:53]

Hi,
Here is another CL which adds metrics to AEC3.

PTAL

[peah-webrtc, 2017-02-28 01:26:59]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 01:27:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 02:13:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 02:13:35]

Dry run: Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/20321)

[hlundin-webrtc, 2017-02-28 10:04:23]

Nice. See comments inline.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/aec3_common.h (right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/aec3_common.h:29: constexpr int
kMetricsReportingInterval = 10 * 250;
What is the unit? Milliseconds?

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/block_processor_metrics.cc (right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:19:
ResetMetrics();
No need to call reset here, since nothing changes from the initialized values.
Thus, you can make this = default, or maybe even omit the ctor from h- and
cc-files.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:22: void
BlockProcessorMetrics::ResetMetrics() {
Wrong order of methods compared to h file.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:39:
value_to_report = 0;
Is this some kind of enum metric? If so, I suggest you define the enum properly.
And use RTC_HISTOGRAM_ENUMERATION.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:66:
capture_block_counter_ = 0;
Shouldn't buffer_render_calls_ be reset too?

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/block_processor_metrics.h (right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.h:29: // Returns
true if the metrics has just been reported, otherwise false.
has -> have

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.h:37: bool
metric_reported_ = false;
metrics_reported_ (plural)

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc (right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc:75: active_render_
+= (aec_state.ActiveRender() ? 1 : 0);
active_render_count_

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc:201:
RTC_DCHECK_EQ(kMetricsReportingInterval, block_counter_);
So every 11 times you are not reporting anything. Why don't you incorporate this
into the kMetricsCollectionBlocks + 9 case?

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc:233: void
TransformDbMetricForReporting(bool negate,
I'm not fond of this method altering the value. Calling it twice will be really
strange (not intended to be used like that, I know).

I suggest you make this method return the modified value, and take the input
value "by value" instead of as a pointer. Also, you can skip the
FormatForReporting method, and simply call TransformDbMetricForReporting where
the metrics are actually reported to UMA.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc:237: float
scaleing,
scaleing -> scaling

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/echo_remover_metrics.h (right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.h:45: // Returns true
if the metrics has just been reported, otherwise false.
has -> have

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.h:59: bool
metric_reported_ = false;
metrics_reported_

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/echo_remover_metrics_unittest.cc
(right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics_unittest.cc:38: //
Verifies the updating functionality of UpdateDBMetric.
UpdateDbMetric

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc
(right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:21:
ResetMetrics();
No need.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:24: void
RenderDelayControllerMetrics::ResetMetrics() {
Wrong order of methods.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:59:
value_to_report = 0;
Again, some kind of enum?

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:69:
RTC_HISTOGRAM_COUNTS_LINEAR(
RTC_HISTOGRAM_ENUMERATION

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:84:
RTC_HISTOGRAM_COUNTS_LINEAR("WebRTC.Audio.EchoCanceller.DelayChanges",
RTC_HISTOGRAM_ENUMERATION

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.h
(right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.h:27: //
Returns true if the metrics has just been reported, otherwise false.
has -> have

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.h:39: bool
metric_reported_ = false;
metrics_reported_

[peah-webrtc, 2017-02-28 12:57:26]

Thanks for the comments!
I've revised the code according to your comments.

PTAL

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/aec3_common.h (right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/aec3_common.h:29: constexpr int
kMetricsReportingInterval = 10 * 250;
On 2017/02/28 10:04:22, hlundin-webrtc wrote:
> What is the unit? Milliseconds?

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/block_processor_metrics.cc (right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:19:
ResetMetrics();
On 2017/02/28 10:04:22, hlundin-webrtc wrote:
> No need to call reset here, since nothing changes from the initialized values.
> Thus, you can make this = default, or maybe even omit the ctor from h- and
> cc-files.

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:22: void
BlockProcessorMetrics::ResetMetrics() {
On 2017/02/28 10:04:22, hlundin-webrtc wrote:
> Wrong order of methods compared to h file.

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:39:
value_to_report = 0;
On 2017/02/28 10:04:22, hlundin-webrtc wrote:
> Is this some kind of enum metric? If so, I suggest you define the enum
properly.
> And use RTC_HISTOGRAM_ENUMERATION.

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:66:
capture_block_counter_ = 0;
On 2017/02/28 10:04:22, hlundin-webrtc wrote:
> Shouldn't buffer_render_calls_ be reset too?

Good find! The call to ResetMetrics() was missing.

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/block_processor_metrics.h (right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.h:29: // Returns
true if the metrics has just been reported, otherwise false.
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> has -> have

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.h:37: bool
metric_reported_ = false;
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> metrics_reported_ (plural)

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc (right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc:75: active_render_
+= (aec_state.ActiveRender() ? 1 : 0);
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> active_render_count_

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc:201:
RTC_DCHECK_EQ(kMetricsReportingInterval, block_counter_);
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> So every 11 times you are not reporting anything. Why don't you incorporate
this
> into the kMetricsCollectionBlocks + 9 case?

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc:233: void
TransformDbMetricForReporting(bool negate,
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> I'm not fond of this method altering the value. Calling it twice will be
really
> strange (not intended to be used like that, I know).
> 
> I suggest you make this method return the modified value, and take the input
> value "by value" instead of as a pointer. Also, you can skip the
> FormatForReporting method, and simply call TransformDbMetricForReporting where
> the metrics are actually reported to UMA.

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc:237: float
scaleing,
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> scaleing -> scaling

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/echo_remover_metrics.h (right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.h:45: // Returns true
if the metrics has just been reported, otherwise false.
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> has -> have

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.h:59: bool
metric_reported_ = false;
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> metrics_reported_

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/echo_remover_metrics_unittest.cc
(right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics_unittest.cc:38: //
Verifies the updating functionality of UpdateDBMetric.
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> UpdateDbMetric

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc
(right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:21:
ResetMetrics();
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> No need.

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:24: void
RenderDelayControllerMetrics::ResetMetrics() {
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> Wrong order of methods.

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:59:
value_to_report = 0;
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> Again, some kind of enum?

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:69:
RTC_HISTOGRAM_COUNTS_LINEAR(
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> RTC_HISTOGRAM_ENUMERATION

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:84:
RTC_HISTOGRAM_COUNTS_LINEAR("WebRTC.Audio.EchoCanceller.DelayChanges",
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> RTC_HISTOGRAM_ENUMERATION

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.h
(right):

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.h:27: //
Returns true if the metrics has just been reported, otherwise false.
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> has -> have

Done.

https://codereview.webrtc.org/2722453002/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.h:39: bool
metric_reported_ = false;
On 2017/02/28 10:04:23, hlundin-webrtc wrote:
> metrics_reported_

Done.

[hlundin-webrtc, 2017-02-28 13:10:03]

LGTM with a few comments.

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/block_processor_metrics.cc (right):

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:84:
capture_block_counter_ = 0;
Any reason not to include capture_block_counter_ = 0 in ResetMetrics()?

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc (right):

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc:223:
RTC_HISTOGRAM_ENUMERATION(
If it is just true or false, use RTC_HISTOGRAM_BOOLEAN instead. Several places.

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc
(right):

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:111:
void RenderDelayControllerMetrics::ResetMetrics() {
Not used anymore.

[peah-webrtc, 2017-02-28 13:18:41]

Patchset #3 (id:100001) has been deleted

[peah-webrtc, 2017-02-28 13:19:06]

Thanks for the comments! I've uploaded a new patch.

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/block_processor_metrics.cc (right):

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:84:
capture_block_counter_ = 0;
On 2017/02/28 13:10:03, hlundin-webrtc wrote:
> Any reason not to include capture_block_counter_ = 0 in ResetMetrics()?

I prefer to have it here as the the increment and check of the counter is also
here. Otherwise, I feel it is less clear that the periodic updating works as
intended.

WDYT?

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc (right):

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc:223:
RTC_HISTOGRAM_ENUMERATION(
On 2017/02/28 13:10:03, hlundin-webrtc wrote:
> If it is just true or false, use RTC_HISTOGRAM_BOOLEAN instead. Several
places.

Done.

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc
(right):

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_controller_metrics.cc:111:
void RenderDelayControllerMetrics::ResetMetrics() {
On 2017/02/28 13:10:03, hlundin-webrtc wrote:
> Not used anymore.

Done.

[hlundin-webrtc, 2017-02-28 14:02:28]

lgtm

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/block_processor_metrics.cc (right):

https://codereview.webrtc.org/2722453002/diff/80001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor_metrics.cc:84:
capture_block_counter_ = 0;
On 2017/02/28 13:19:06, peah-webrtc wrote:
> On 2017/02/28 13:10:03, hlundin-webrtc wrote:
> > Any reason not to include capture_block_counter_ = 0 in ResetMetrics()?
> 
> I prefer to have it here as the the increment and check of the counter is also
> here. Otherwise, I feel it is less clear that the periodic updating works as
> intended.
> 
> WDYT?

OK.

[peah-webrtc, 2017-02-28 23:09:26]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2017-02-28 23:09:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2722453002/#ps160001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-02-28 23:09:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[peah-webrtc, 2017-02-28 23:23:21]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2017-02-28 23:23:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2722453002/#ps200001 (title:
"Changed some of the names for the metrics")

[commit-bot: I haz the power, 2017-02-28 23:23:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-01 00:32:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 00:32:21]

Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/20382)

[peah-webrtc, 2017-03-01 05:49:27]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2017-03-01 05:49:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-01 06:08:54]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1488347367935210,
"parent_rev": "999cf2bd7c66ec1944ad48d00fb6a54c1985774e", "commit_rev":
"e985b3fe49738b78d9b19fad8d24eae81628c181"}

[commit-bot: I haz the power, 2017-03-01 06:08:57]

Description was changed from

==========
Adding metrics to AEC3.

This CL adds metrics reporting to AEC3.

BUG=webrtc:6018
==========

to

==========
Adding metrics to AEC3.

This CL adds metrics reporting to AEC3.

BUG=webrtc:6018

Review-Url: https://codereview.webrtc.org/2722453002
Cr-Commit-Position: refs/heads/master@{#16929}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e985b3fe49738b78d9b19fad8...
==========

[commit-bot: I haz the power, 2017-03-01 06:08:58]

Committed patchset #7 (id:200001) as
https://chromium.googlesource.com/external/webrtc/+/e985b3fe49738b78d9b19fad8...