Fix flaky ViEEncoder tests.

Fix flaky ViEEncoder tests.

This CL fixes two issues. The first is a tsan complaint about a data
race. The test had a fix to make it deterministic but the race still
existed, so this adds locks around the critical section to appease
the sanitizer.

The second, more annoying issue, is that occasionally the test would
start before the encoder had been configured, as this happens
asynchronously on a task queue. This would cause frames to be queued
up and dropped, but not where we expected them to be dropped.
This was causing some tests to fail very occasionally. I've added
a synchronisation mechanism by posting a barrier task on the queue
and not proceeding with the tests until it finishes.

BUG=webrtc:7217, webrtc:7232, webrtc:7260
Review-Url: https://codereview.webrtc.org/2722183004
Cr-Commit-Position: refs/heads/master@{#16995}
Committed: https://chromium.googlesource.com/external/webrtc/+/2fc52544b02aab6a206ae76dc220e7c8409c9b31

[kthelgason, 2017-03-02 13:08:21]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 13:08:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kthelgason, 2017-03-02 13:17:31]

kthelgason@webrtc.org changed reviewers:
+ magjed@webrtc.org, sprang@webrtc.org

[kthelgason, 2017-03-02 13:17:31]

Please take a look :)

[magjed_webrtc, 2017-03-02 13:26:23]

lgtm ;)

[commit-bot: I haz the power, 2017-03-02 13:47:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 13:47:54]

Dry run: This issue passed the CQ dry run.

[sprang_webrtc, 2017-03-02 15:15:05]

lgtm

[kthelgason, 2017-03-03 08:22:17]

The CQ bit was checked by kthelgason@webrtc.org

[commit-bot: I haz the power, 2017-03-03 08:22:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 08:24:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488529337123730, "parent_rev":
"e7b8c3759b6865e1dec3bef84a6d82362ea9d855", "commit_rev":
"2fc52544b02aab6a206ae76dc220e7c8409c9b31"}

[commit-bot: I haz the power, 2017-03-03 08:24:43]

Description was changed from

==========
Fix flaky ViEEncoder tests.

This CL fixes two issues. The first is a tsan complaint about a data
race. The test had a fix to make it deterministic but the race still
existed, so this adds locks around the critical section to appease
the sanitizer.

The second, more annoying issue, is that occasionally the test would
start before the encoder had been configured, as this happens
asynchronously on a task queue. This would cause frames to be queued
up and dropped, but not where we expected them to be dropped.
This was causing some tests to fail very occasionally. I've added
a synchronisation mechanism by posting a barrier task on the queue
and not proceeding with the tests until it finishes.

BUG=webrtc:7217, webrtc:7232, webrtc:7260
==========

to

==========
Fix flaky ViEEncoder tests.

This CL fixes two issues. The first is a tsan complaint about a data
race. The test had a fix to make it deterministic but the race still
existed, so this adds locks around the critical section to appease
the sanitizer.

The second, more annoying issue, is that occasionally the test would
start before the encoder had been configured, as this happens
asynchronously on a task queue. This would cause frames to be queued
up and dropped, but not where we expected them to be dropped.
This was causing some tests to fail very occasionally. I've added
a synchronisation mechanism by posting a barrier task on the queue
and not proceeding with the tests until it finishes.

BUG=webrtc:7217, webrtc:7232, webrtc:7260

Review-Url: https://codereview.webrtc.org/2722183004
Cr-Commit-Position: refs/heads/master@{#16995}
Committed:
https://chromium.googlesource.com/external/webrtc/+/2fc52544b02aab6a206ae76dc...
==========

[commit-bot: I haz the power, 2017-03-03 08:24:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/2fc52544b02aab6a206ae76dc...