Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2722173003: Conversational Speech generator tool (Closed)

Created:
3 years, 9 months ago by AleBzk
Modified:
3 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Readme file with example that explains how the conversational speech generator tool should work. BUG=webrtc:7218 NOTRY=True Review-Url: https://codereview.webrtc.org/2722173003 Cr-Commit-Position: refs/heads/master@{#17010} Committed: https://chromium.googlesource.com/external/webrtc/+/810025f9e92bfe43c0340fba8051d816618bf9a8

Patch Set 1 #

Patch Set 2 : Remarks #

Total comments: 2

Patch Set 3 : Multiple tracks in a row from the same speaker, multiple-end conversations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
A webrtc/modules/audio_processing/test/py_conversational_speech/OWNERS View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/py_conversational_speech/README.md View 1 2 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
AleBzk
This CL starts an additional Python tool which I need to create suitable probing signals ...
3 years, 9 months ago (2017-03-01 13:08:08 UTC) #3
hlundin-webrtc
LGTM with one question/comment. https://codereview.webrtc.org/2722173003/diff/20001/webrtc/modules/audio_processing/test/py_conversational_speech/README.md File webrtc/modules/audio_processing/test/py_conversational_speech/README.md (right): https://codereview.webrtc.org/2722173003/diff/20001/webrtc/modules/audio_processing/test/py_conversational_speech/README.md#newcode28 webrtc/modules/audio_processing/test/py_conversational_speech/README.md:28: ``` a1 0 Is this ...
3 years, 9 months ago (2017-03-03 14:01:10 UTC) #4
AleBzk
Thanks a lot for your comment! I reviewed the example allowing for multiple tracks in ...
3 years, 9 months ago (2017-03-03 15:27:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2722173003/40001
3 years, 9 months ago (2017-03-03 15:29:17 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 15:31:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/810025f9e92bfe43c0340fba8...

Powered by Google App Engine
This is Rietveld 408576698