Create unit test for VideoReceiveStream.

Create unit test for VideoReceiveStream.

- Create an unit test skeleton for VideoReceiveStream.
- Add an actual test case for creating a frame from H264 Sprop Parameter
  Sets and an Rtp H264 IDR Nalu.

BUG=webrtc:5948
Review-Url: https://codereview.webrtc.org/2721653002
Cr-Commit-Position: refs/heads/master@{#16892}
Committed: https://chromium.googlesource.com/external/webrtc/+/f2183ffbf6dd0e99207f0c8386ab06643ea2c231

[johan, 2017-02-27 16:25:35]

The CQ bit was checked by johan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 16:25:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[johan, 2017-02-27 16:36:03]

johan@webrtc.org changed reviewers:
+ sprang@webrtc.org

[johan, 2017-02-27 16:36:04]

This is a subset of https://codereview.webrtc.org/2721653002 .
 CongestionController is gone from the VideoReceiveStream constructor. So there
is no more need to mock it for unit testing VideoReceiveStream.

[commit-bot: I haz the power, 2017-02-27 17:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:11:50]

Dry run: This issue passed the CQ dry run.

[sprang_webrtc, 2017-02-28 08:53:58]

lgtm with question

https://codereview.webrtc.org/2721653002/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream_unittest.cc (right):

https://codereview.webrtc.org/2721653002/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream_unittest.cc:116: RtpPacketToSend
rtppacket{nullptr};
Why {} instead of ()?

[johan, 2017-02-28 09:06:21]

https://codereview.webrtc.org/2721653002/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream_unittest.cc (right):

https://codereview.webrtc.org/2721653002/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream_unittest.cc:116: RtpPacketToSend
rtppacket{nullptr};
On 2017/02/28 08:53:57, språng wrote:
> Why {} instead of ()?

Actually no good reason for {} in this place. Changing them to () before
landing.

[johan, 2017-02-28 09:07:56]

The CQ bit was checked by johan@webrtc.org

[johan, 2017-02-28 09:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2721653002/#ps20001 (title:
"Replace curly braces initializer by paranthesis.")

[commit-bot: I haz the power, 2017-02-28 09:08:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 09:33:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488272876410650,
"parent_rev": "b1175bb101a3c9682db929ae476732f4c43fb9a4", "commit_rev":
"f2183ffbf6dd0e99207f0c8386ab06643ea2c231"}

[commit-bot: I haz the power, 2017-02-28 09:33:12]

Description was changed from

==========
Create unit test for VideoReceiveStream.

- Create an unit test skeleton for VideoReceiveStream.
- Add an actual test case for creating a frame from H264 Sprop Parameter
  Sets and an Rtp H264 IDR Nalu.

BUG=webrtc:5948
==========

to

==========
Create unit test for VideoReceiveStream.

- Create an unit test skeleton for VideoReceiveStream.
- Add an actual test case for creating a frame from H264 Sprop Parameter
  Sets and an Rtp H264 IDR Nalu.

BUG=webrtc:5948

Review-Url: https://codereview.webrtc.org/2721653002
Cr-Commit-Position: refs/heads/master@{#16892}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f2183ffbf6dd0e99207f0c838...
==========

[commit-bot: I haz the power, 2017-02-28 09:33:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/f2183ffbf6dd0e99207f0c838...