Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2721583002: iOS AppRTCMobile: Fix SocketRocket bug (Closed)

Created:
3 years, 9 months ago by kthelgason
Modified:
3 years, 9 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS AppRTCMobile: Fix SocketRocket bug Fixes a bug where a missing boolean-not causes AppRTCMobile to always crash on an assert when built for Debug. BUG=None NOTRY=True TBR=magjed@webrtc.org Review-Url: https://codereview.webrtc.org/2721583002 Cr-Commit-Position: refs/heads/master@{#16865} Committed: https://chromium.googlesource.com/external/webrtc/+/99ce6cdf232a9cb473536ee7905efb245cbfab3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/examples/objc/AppRTCMobile/third_party/SocketRocket/SRWebSocket.m View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
kthelgason
Magnus: please take a look
3 years, 9 months ago (2017-02-27 12:37:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2721583002/1
3 years, 9 months ago (2017-02-27 12:39:48 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-02-27 12:39:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2721583002/1
3 years, 9 months ago (2017-02-27 13:18:04 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 13:20:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/99ce6cdf232a9cb473536ee79...

Powered by Google App Engine
This is Rietveld 408576698