Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2721463003: Remove unused RemoteBitrateEstimator::IncomingPacketFeedbackVector() (Closed)

Created:
3 years, 9 months ago by elad.alon
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused RemoteBitrateEstimator::IncomingPacketFeedbackVector() BUG=None Review-Url: https://codereview.webrtc.org/2721463003 Cr-Commit-Position: refs/heads/master@{#17058} Committed: https://chromium.googlesource.com/external/webrtc/+/5419ac8c026bdbd4f5690a03af106bc3cb7211dd

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Messages

Total messages: 23 (10 generated)
elad.alon_webrtc.org
Ready
3 years, 9 months ago (2017-02-27 10:45:44 UTC) #2
stefan-webrtc
lgtm
3 years, 9 months ago (2017-03-01 22:35:30 UTC) #3
michaelt
Shouldn't we remove this as well ? https://cs.chromium.org/chromium/src/third_party/webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitrate_estimator.h?type=cs&q=%22MOCK_METHOD1(IncomingPacketFeedbackVector%22&l=29
3 years, 9 months ago (2017-03-02 12:46:26 UTC) #4
elad.alon_webrtc.org
On 2017/03/02 12:46:26, michaelt wrote: > Shouldn't we remove this as well ? > https://cs.chromium.org/chromium/src/third_party/webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitrate_estimator.h?type=cs&q=%22MOCK_METHOD1(IncomingPacketFeedbackVector%22&l=29 ...
3 years, 9 months ago (2017-03-02 13:13:53 UTC) #5
elad.alon_webrtc.org
On 2017/03/02 13:13:53, elad.alon wrote: > On 2017/03/02 12:46:26, michaelt wrote: > > Shouldn't we ...
3 years, 9 months ago (2017-03-02 13:14:51 UTC) #6
elad.alon_webrtc.org
On 2017/03/02 13:14:51, elad.alon wrote: > On 2017/03/02 13:13:53, elad.alon wrote: > > On 2017/03/02 ...
3 years, 9 months ago (2017-03-02 16:51:45 UTC) #7
stefan-webrtc
add BUG=none lgtm
3 years, 9 months ago (2017-03-03 19:36:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2721463003/30007
3 years, 9 months ago (2017-03-06 09:55:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14516)
3 years, 9 months ago (2017-03-06 09:59:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2721463003/50001
3 years, 9 months ago (2017-03-06 10:17:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14518)
3 years, 9 months ago (2017-03-06 10:21:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2721463003/50001
3 years, 9 months ago (2017-03-06 10:25:09 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 11:11:10 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/external/webrtc/+/5419ac8c026bdbd4f5690a03a...

Powered by Google App Engine
This is Rietveld 408576698