Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2721303002: Cleanup video test target dependencies in video_test_common. (Closed)

Created:
3 years, 9 months ago by perkj_webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleanup video test target dependencies in video_test_common. The purpose is to fix (Asan discovered) duble definitions in upstream project. BUG=none Review-Url: https://codereview.webrtc.org/2721303002 Cr-Commit-Position: refs/heads/master@{#16939} Committed: https://chromium.googlesource.com/external/webrtc/+/c5726c1579358260a7587ed05943f01dba506fa6

Patch Set 1 #

Patch Set 2 : call_test depend on frame_generator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M webrtc/test/BUILD.gn View 1 4 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
perkj_webrtc
please?
3 years, 9 months ago (2017-03-01 07:52:16 UTC) #4
danilchap
lgtm
3 years, 9 months ago (2017-03-01 11:33:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2721303002/20001
3 years, 9 months ago (2017-03-01 11:34:34 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 11:37:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c5726c1579358260a7587ed05...

Powered by Google App Engine
This is Rietveld 408576698