Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2721123005: VoE Utility: Fix a naming nit in RemixAndResample (Closed)

Created:
3 years, 9 months ago by hlundin-webrtc
Modified:
3 years, 5 months ago
Reviewers:
the sun, ossu
CC:
webrtc-reviews_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

VoE Utility: Fix a naming nit in RemixAndResample This was pointed out in https://codereview.webrtc.org/2712743004 after committing. BUG=webrtc:7220 NOTRY=True TBR=solenberg@webrtc.org Review-Url: https://codereview.webrtc.org/2721123005 Cr-Commit-Position: refs/heads/master@{#16965} Committed: https://chromium.googlesource.com/external/webrtc/+/fb4f8b6cb430678b0e5d99f222cb0878effefafc

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/voice_engine/utility.cc View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2721123005/1
3 years, 9 months ago (2017-03-02 12:08:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/fb4f8b6cb430678b0e5d99f222cb0878effefafc
3 years, 9 months ago (2017-03-02 12:11:01 UTC) #7
ossu
*Unsolicited drive-by nit review* I believe the original request was to rename the variable "downmixed_audio". ...
3 years, 5 months ago (2017-07-07 11:14:42 UTC) #9
hlundin-webrtc
3 years, 5 months ago (2017-07-07 12:02:51 UTC) #10
Message was sent while issue was closed.
On 2017/07/07 11:14:42, ossu wrote:
> *Unsolicited drive-by nit review*
> 
> I believe the original request was to rename the variable "downmixed_audio".
> 
> https://codereview.webrtc.org/2721123005/diff/1/webrtc/voice_engine/utility.cc
> File webrtc/voice_engine/utility.cc (right):
> 
>
https://codereview.webrtc.org/2721123005/diff/1/webrtc/voice_engine/utility.c...
> webrtc/voice_engine/utility.cc:44: int16_t
> downsmixed_audio[AudioFrame::kMaxDataSizeSamples];
> Perhaps take a closer look at what you actually renamed to here. :)

Fixed in https://codereview.webrtc.org/2976473002/.

Powered by Google App Engine
This is Rietveld 408576698