Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2720613008: Adds profiling support for non-rooted devices (Closed)

Created:
3 years, 9 months ago by henrika_webrtc
Modified:
3 years, 9 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adds profiling support for non-rooted devices. NOTRY=TRUE TBR=kjellander BUG=NONE Review-Url: https://codereview.webrtc.org/2720613008 Cr-Commit-Position: refs/heads/master@{#16901} Committed: https://chromium.googlesource.com/external/webrtc/+/c6106f4102333d250de53905f94ffb6e2010b057

Patch Set 1 #

Patch Set 2 : Initial tests now works for rooted and non-rooted devices #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -35 lines) Patch
M tools-webrtc/android/profiling/perf_setup.sh View 1 11 chunks +28 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2720613008/20001
3 years, 9 months ago (2017-02-28 13:53:31 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/c6106f4102333d250de53905f94ffb6e2010b057
3 years, 9 months ago (2017-02-28 13:55:47 UTC) #8
kjellander_webrtc
3 years, 9 months ago (2017-02-28 17:25:35 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698