Remove |running_| state from NackModule to avoid running a tight loop.

Remove |running_| state from NackModule to avoid running a tight loop.
Also reducing locking in NackModule (and by extension RtpStreamReceiver)

BUG=webrtc:7246
Review-Url: https://codereview.webrtc.org/2720603002
Cr-Commit-Position: refs/heads/master@{#16856}
Committed: https://chromium.googlesource.com/external/webrtc/+/f284b7ff5f265016203f9c4c3f21b22cedd7593e

[tommi, 2017-02-26 21:04:42]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 21:04:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-02-26 21:06:04]

tommi@webrtc.org changed reviewers:
+ philipel@webrtc.org

[commit-bot: I haz the power, 2017-02-26 21:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 21:38:34]

Dry run: Try jobs failed on following builders:
  linux_memcheck on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/5711)

[philipel, 2017-02-27 09:12:45]

Hmmm... The reason we use a unique_ptr<NackModule> was due to it being part of
the new jitter buffer experiment, and we didn't want to even instantiate that
class if the experiment wasn't running.

The idea was to make it a member of RtpStreamReceiver when we clean out the old
jitter buffer.

[philipel, 2017-02-27 09:31:22]

lgtm after some offline discussion, one comment though.

https://codereview.webrtc.org/2720603002/diff/1/webrtc/video/rtp_stream_recei...
File webrtc/video/rtp_stream_receiver.cc (right):

https://codereview.webrtc.org/2720603002/diff/1/webrtc/video/rtp_stream_recei...
webrtc/video/rtp_stream_receiver.cc:540: void
RtpStreamReceiver::FrameContinuous(uint16_t picture_id) {
If |nack_module_| is null then we can return immediately.

[tommi, 2017-02-27 09:35:08]

earlier check in FrameContinuous

[tommi, 2017-02-27 09:35:17]

https://codereview.webrtc.org/2720603002/diff/1/webrtc/video/rtp_stream_recei...
File webrtc/video/rtp_stream_receiver.cc (right):

https://codereview.webrtc.org/2720603002/diff/1/webrtc/video/rtp_stream_recei...
webrtc/video/rtp_stream_receiver.cc:540: void
RtpStreamReceiver::FrameContinuous(uint16_t picture_id) {
On 2017/02/27 09:31:22, philipel wrote:
> If |nack_module_| is null then we can return immediately.

nice - done.

[tommi, 2017-02-27 09:35:35]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2017-02-27 09:35:36]

The patchset sent to the CQ was uploaded after l-g-t-m from philipel@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2720603002/#ps20001 (title:
"earlier check in FrameContinuous")

[commit-bot: I haz the power, 2017-02-27 09:35:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-27 09:59:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488188135612350,
"parent_rev": "92eaec610490ab5f7aa66fae1edf964df1d68345", "commit_rev":
"f284b7ff5f265016203f9c4c3f21b22cedd7593e"}

[commit-bot: I haz the power, 2017-02-27 09:59:38]

Description was changed from

==========
Remove |running_| state from NackModule to avoid running a tight loop.
Also reducing locking in NackModule (and by extension RtpStreamReceiver)

BUG=webrtc:7246
==========

to

==========
Remove |running_| state from NackModule to avoid running a tight loop.
Also reducing locking in NackModule (and by extension RtpStreamReceiver)

BUG=webrtc:7246

Review-Url: https://codereview.webrtc.org/2720603002
Cr-Commit-Position: refs/heads/master@{#16856}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f284b7ff5f265016203f9c4c3...
==========

[commit-bot: I haz the power, 2017-02-27 09:59:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/f284b7ff5f265016203f9c4c3...