Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2720533002: Enable GN check in webrtc/stats (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable GN check in webrtc/stats BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2720533002 Cr-Commit-Position: refs/heads/master@{#16881} Committed: https://chromium.googlesource.com/external/webrtc/+/dcb4b437fad571589bdca5daad6e68ee2ee78840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/stats/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_webrtc
3 years, 9 months ago (2017-02-26 07:01:25 UTC) #3
hbos
lgtm
3 years, 9 months ago (2017-02-27 09:17:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2720533002/1
3 years, 9 months ago (2017-02-27 23:47:03 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 23:53:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/dcb4b437fad571589bdca5daa...

Powered by Google App Engine
This is Rietveld 408576698