Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 2720503003: Enable GN check for webrtc/call (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable GN check for webrtc/call BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2720503003 Cr-Commit-Position: refs/heads/master@{#16882} Committed: https://chromium.googlesource.com/external/webrtc/+/2f1a55583909cdbb234b7da2227afa30150f96d8

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M .gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/call/BUILD.gn View 4 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kjellander_webrtc
3 years, 9 months ago (2017-02-26 06:55:43 UTC) #3
the sun
lgtm
3 years, 9 months ago (2017-02-27 12:51:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2720503003/20001
3 years, 9 months ago (2017-02-27 23:56:14 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 23:57:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/2f1a55583909cdbb234b7da22...

Powered by Google App Engine
This is Rietveld 408576698