Remove saturation warning support from TransmitMixer.

Remove saturation warning support from TransmitMixer.

BUG=none

Review-Url: https://codereview.webrtc.org/2720253002
Cr-Commit-Position: refs/heads/master@{#16913}
Committed: https://chromium.googlesource.com/external/webrtc/+/ba08a140da6cee478c62cf61e857cfee1647bf95

[tommi, 2017-02-28 11:45:44]

Description was changed from

==========
Remove saturation detection support from TransmitMixer.

BUG=none
==========

to

==========
Remove saturation warning support from TransmitMixer.

BUG=none
==========

[tommi, 2017-02-28 11:45:54]

tommi@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[tommi, 2017-02-28 11:45:59]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 11:46:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-02-28 11:46:43]

https://codereview.webrtc.org/2720253002/diff/1/webrtc/voice_engine/transmit_...
File webrtc/voice_engine/transmit_mixer.cc (left):

https://codereview.webrtc.org/2720253002/diff/1/webrtc/voice_engine/transmit_...
webrtc/voice_engine/transmit_mixer.cc:1081: rtc::CritScope cs(&_critSect);
look, we can haz one less locks!

[commit-bot: I haz the power, 2017-02-28 11:59:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 11:59:41]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/18074)

[hlundin-webrtc, 2017-02-28 12:56:47]

Disclaimer: I don't know this code.
RS-LGTM

https://codereview.webrtc.org/2720253002/diff/1/webrtc/voice_engine/transmit_...
File webrtc/voice_engine/transmit_mixer.h (right):

https://codereview.webrtc.org/2720253002/diff/1/webrtc/voice_engine/transmit_...
webrtc/voice_engine/transmit_mixer.h:29: // Should this be turned on in Chromium
as well?
I believe it is.

[tommi, 2017-02-28 12:59:55]

On 2017/02/28 12:56:47, hlundin-webrtc wrote:
> Disclaimer: I don't know this code.
> RS-LGTM
> 
>
https://codereview.webrtc.org/2720253002/diff/1/webrtc/voice_engine/transmit_...
> File webrtc/voice_engine/transmit_mixer.h (right):
> 
>
https://codereview.webrtc.org/2720253002/diff/1/webrtc/voice_engine/transmit_...
> webrtc/voice_engine/transmit_mixer.h:29: // Should this be turned on in
Chromium
> as well?
> I believe it is.

But should it?  If it should not, then I can add a check there for chromium
builds.

[hlundin-webrtc, 2017-02-28 14:19:43]

On 2017/02/28 12:59:55, tommi (webrtc) wrote:
> On 2017/02/28 12:56:47, hlundin-webrtc wrote:
> > Disclaimer: I don't know this code.
> > RS-LGTM
> > 
> >
>
https://codereview.webrtc.org/2720253002/diff/1/webrtc/voice_engine/transmit_...
> > File webrtc/voice_engine/transmit_mixer.h (right):
> > 
> >
>
https://codereview.webrtc.org/2720253002/diff/1/webrtc/voice_engine/transmit_...
> > webrtc/voice_engine/transmit_mixer.h:29: // Should this be turned on in
> Chromium
> > as well?
> > I believe it is.
> 
> But should it?  If it should not, then I can add a check there for chromium
> builds.

This is the transient suppression which removes keyboard typing noises from the
captured audio. I think Chrome/Chromium is exactly where we want it to be
enabled.

[henrika_webrtc, 2017-02-28 14:28:49]

Don't know the details but isn't the actual detection (and usage of such
detection)
and the parts that Tommi removes here two different things?

AFAIK, Tommi only removes a log and not the detection as such.

[tommi, 2017-02-28 14:42:03]

Fix compile issue on ios and android

[tommi, 2017-02-28 14:42:08]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 14:42:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-02-28 14:43:12]

Remove comment

[tommi, 2017-02-28 15:42:06]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2017-02-28 15:42:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2720253002/#ps40001 (title:
"Remove comment")

[commit-bot: I haz the power, 2017-02-28 15:42:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 16:25:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488296526993130,
"parent_rev": "e3e902eef9dcf94342336cd982076fe69df2db4b", "commit_rev":
"ba08a140da6cee478c62cf61e857cfee1647bf95"}

[commit-bot: I haz the power, 2017-02-28 16:25:15]

Description was changed from

==========
Remove saturation warning support from TransmitMixer.

BUG=none
==========

to

==========
Remove saturation warning support from TransmitMixer.

BUG=none

Review-Url: https://codereview.webrtc.org/2720253002
Cr-Commit-Position: refs/heads/master@{#16913}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ba08a140da6cee478c62cf61e...
==========

[commit-bot: I haz the power, 2017-02-28 16:25:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/ba08a140da6cee478c62cf61e...