Audio level evaluation score.

Audio level evaluation score.

BUG=webrtc:7218
NOTRY=True

Review-Url: https://codereview.webrtc.org/2720233002
Cr-Commit-Position: refs/heads/master@{#17508}
Committed: https://chromium.googlesource.com/external/webrtc/+/c533df203cfdfcf29287591ce591e2715269f45e

[AleBzk, 2017-02-28 16:03:50]

Description was changed from

==========
Audio level evlauation score.

BUG=webrtc:7218
NOTRY=True
==========

to

==========
Audio level evlauation score.

BUG=webrtc:7218
NOTRY=True
==========

[AleBzk, 2017-02-28 16:03:50]

alessiob@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[AleBzk, 2017-02-28 16:19:42]

Hi Henrik,

I'm working on a Python tool to evaluate the APM module in WebRTC. The library
includes several evaluation scores (e.g., POLQA, speech level). This CL
implements the audio level score.

[kjellander_webrtc, 2017-03-03 05:11:58]

lgtm

https://codereview.webrtc.org/2720233002/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py
(right):

https://codereview.webrtc.org/2720233002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py:107:
self._score = self._tested_signal.dBFS - self._reference_signal.dBFS
Does it make sense to use the absolute value here or is it interesting to have
the sign of the difference?

[kjellander_webrtc, 2017-03-03 05:22:42]

Description was changed from

==========
Audio level evlauation score.

BUG=webrtc:7218
NOTRY=True
==========

to

==========
Audio level evaluation score.

BUG=webrtc:7218
NOTRY=True
==========

[AleBzk, 2017-03-03 14:01:23]

https://codereview.webrtc.org/2720233002/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py
(right):

https://codereview.webrtc.org/2720233002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py:107:
self._score = self._tested_signal.dBFS - self._reference_signal.dBFS
On 2017/03/03 05:11:58, kjellander_webrtc wrote:
> Does it make sense to use the absolute value here or is it interesting to have
> the sign of the difference?

Thanks for asking! The second because, with sign, we can distinguish an
attenuation from an amplification.

[AleBzk, 2017-04-03 15:17:03]

The CQ bit was checked by alessiob@webrtc.org

[AleBzk, 2017-04-03 15:17:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2720233002/#ps20001 (title:
"rebase")

[commit-bot: I haz the power, 2017-04-03 15:17:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-03 15:20:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491232623315320,
"parent_rev": "54ad3df1d290b202bbd3917b170df5e7cbf95f29", "commit_rev":
"c533df203cfdfcf29287591ce591e2715269f45e"}

[commit-bot: I haz the power, 2017-04-03 15:20:21]

Description was changed from

==========
Audio level evaluation score.

BUG=webrtc:7218
NOTRY=True
==========

to

==========
Audio level evaluation score.

BUG=webrtc:7218
NOTRY=True

Review-Url: https://codereview.webrtc.org/2720233002
Cr-Commit-Position: refs/heads/master@{#17508}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c533df203cfdfcf29287591ce...
==========

[commit-bot: I haz the power, 2017-04-03 15:20:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c533df203cfdfcf29287591ce...