Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2720203003: Single simulation runner (Closed)

Created:
3 years, 9 months ago by AleBzk
Modified:
3 years, 8 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Single simulation runner. BUG=webrtc:7218 NOTRY=True Review-Url: https://codereview.webrtc.org/2720203003 Cr-Commit-Position: refs/heads/master@{#17510} Committed: https://chromium.googlesource.com/external/webrtc/+/eb4662a64d8d88cda0e1606817f36f166122492b

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/audioproc_wrapper.py View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py View 1 1 chunk +32 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
AleBzk
Hi Ivo, This CL adds a method that runs a single APM simulation.
3 years, 9 months ago (2017-02-28 10:36:03 UTC) #3
ivoc
Nice, lgtm with one comment. https://codereview.webrtc.org/2720203003/diff/1/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py File webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py (right): https://codereview.webrtc.org/2720203003/diff/1/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py#newcode104 webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py:104: input_signal_filepath=input_filepath, Please use spaces ...
3 years, 9 months ago (2017-03-01 23:22:33 UTC) #4
AleBzk
Thanks Ivo! I replied to your comment. https://codereview.webrtc.org/2720203003/diff/1/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py File webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py (right): https://codereview.webrtc.org/2720203003/diff/1/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py#newcode104 webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py:104: input_signal_filepath=input_filepath, On ...
3 years, 9 months ago (2017-03-02 08:30:08 UTC) #5
ivoc
https://codereview.webrtc.org/2720203003/diff/1/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py File webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py (right): https://codereview.webrtc.org/2720203003/diff/1/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py#newcode104 webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py:104: input_signal_filepath=input_filepath, On 2017/03/02 08:30:08, AleBzk wrote: > On 2017/03/01 ...
3 years, 9 months ago (2017-03-02 19:16:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2720203003/20001
3 years, 8 months ago (2017-04-03 15:32:07 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 15:34:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/eb4662a64d8d88cda0e160681...

Powered by Google App Engine
This is Rietveld 408576698