Fix rare race in ViEEncoderTest.UMACpuLimitedResolutionInPercent

Fix rare race in ViEEncoderTest.UMACpuLimitedResolutionInPercent

The test aims to synchronize by waiting for the last sent frame, using
sink_.WaitForEncodedFrame(). Then it stops the vie_encoder instance and
finally reset the SendStatsProxy to trigger UMA stats to be registered.

The problem is that the callback that triggers WaitForEncodedFrame() to
release will call FrameSent() on the overuse detecter just after that,
and so it may try to update the stats proxy while it is being deleted.

To prevent this, simply destroy the vie_encoder instance too, so that
we know that the task queue has been stopped.

BUG=None

Review-Url: https://codereview.webrtc.org/2720183004
Cr-Commit-Position: refs/heads/master@{#16914}
Committed: https://chromium.googlesource.com/external/webrtc/+/f8ee65ead6e16cbb1c4311b9fd596a3435ec2f9a

[sprang_webrtc, 2017-02-28 09:53:56]

sprang@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[åsapersson, 2017-02-28 15:52:02]

lgtm

[sprang_webrtc, 2017-02-28 16:01:52]

The CQ bit was checked by sprang@webrtc.org

[commit-bot: I haz the power, 2017-02-28 16:01:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 16:49:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488297712588720, "parent_rev":
"ba08a140da6cee478c62cf61e857cfee1647bf95", "commit_rev":
"f8ee65ead6e16cbb1c4311b9fd596a3435ec2f9a"}

[commit-bot: I haz the power, 2017-02-28 16:49:36]

Description was changed from

==========
Fix rare race in ViEEncoderTest.UMACpuLimitedResolutionInPercent

The test aims to synchronize by waiting for the last sent frame, using
sink_.WaitForEncodedFrame(). Then it stops the vie_encoder instance and
finally reset the SendStatsProxy to trigger UMA stats to be registered.

The problem is that the callback that triggers WaitForEncodedFrame() to
release will call FrameSent() on the overuse detecter just after that,
and so it may try to update the stats proxy while it is being deleted.

To prevent this, simply destroy the vie_encoder instance too, so that
we know that the task queue has been stopped.

BUG=None
==========

to

==========
Fix rare race in ViEEncoderTest.UMACpuLimitedResolutionInPercent

The test aims to synchronize by waiting for the last sent frame, using
sink_.WaitForEncodedFrame(). Then it stops the vie_encoder instance and
finally reset the SendStatsProxy to trigger UMA stats to be registered.

The problem is that the callback that triggers WaitForEncodedFrame() to
release will call FrameSent() on the overuse detecter just after that,
and so it may try to update the stats proxy while it is being deleted.

To prevent this, simply destroy the vie_encoder instance too, so that
we know that the task queue has been stopped.

BUG=None

Review-Url: https://codereview.webrtc.org/2720183004
Cr-Commit-Position: refs/heads/master@{#16914}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f8ee65ead6e16cbb1c4311b9f...
==========

[commit-bot: I haz the power, 2017-02-28 16:49:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f8ee65ead6e16cbb1c4311b9f...