Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2719753002: Enable GN check for webrtc/modules/video_processing (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable GN check for webrtc/modules/video_processing BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2719753002 Cr-Commit-Position: refs/heads/master@{#17106} Committed: https://chromium.googlesource.com/external/webrtc/+/34b7a9186269b5ce8ac84c285715679f7edd37ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M webrtc/modules/video_processing/BUILD.gn View 4 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_webrtc
I'm not entirely sure the refactoring makes sense just to enable GN check on those ...
3 years, 9 months ago (2017-02-27 01:17:55 UTC) #2
stefan-webrtc
lgtm
3 years, 9 months ago (2017-03-08 08:38:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2719753002/1
3 years, 9 months ago (2017-03-08 09:38:59 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 09:41:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/34b7a9186269b5ce8ac84c285...

Powered by Google App Engine
This is Rietveld 408576698