Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2719733002: Replace NULL with nullptr or null in webrtc/audio/ and common_audio/. (Closed)

Created:
3 years, 9 months ago by Taylor Brandstetter
Modified:
3 years, 9 months ago
Reviewers:
tommi, tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace NULL with nullptr or null in webrtc/audio/ and common_audio/. BUG=webrtc:7147 Review-Url: https://codereview.webrtc.org/2719733002 Cr-Commit-Position: refs/heads/master@{#16843} Committed: https://chromium.googlesource.com/external/webrtc/+/922246a353acff8445d4b104f0271befff2bfa68

Patch Set 1 #

Patch Set 2 : Fixing test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M webrtc/audio/audio_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/audio_send_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/fir_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/resampler/resampler.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/ring_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/ring_buffer_unittest.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M webrtc/common_audio/signal_processing/include/real_fft.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/signal_processing/include/signal_processing_library.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/signal_processing/real_fft_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/vad/include/webrtc_vad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/vad/vad_core.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/vad/vad_core_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/common_audio/wav_file.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Taylor Brandstetter
PTAL. I scanned through these files and didn't find anything abnormal.
3 years, 9 months ago (2017-02-26 01:57:34 UTC) #2
tommi
lgtm (tina is ooo right now, so I'm stepping in)
3 years, 9 months ago (2017-02-26 12:15:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2719733002/20001
3 years, 9 months ago (2017-02-26 12:15:34 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-02-26 12:18:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/922246a353acff8445d4b104f...

Powered by Google App Engine
This is Rietveld 408576698