Rewrite rtc::Bind using variadic templates.

Rewrite rtc::Bind using variadic templates.

I'd like to make a change to rtc::Bind in another CL, and that will
be easier if there are fewer lines of code to modify.

BUG=None

Review-Url: https://codereview.webrtc.org/2719683002
Cr-Commit-Position: refs/heads/master@{#16838}
Committed: https://chromium.googlesource.com/external/webrtc/+/08187d41ca45e4671e41856785590d2408c129b6

[Taylor Brandstetter, 2017-02-25 09:30:35]

The CQ bit was checked by deadbeef@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 09:30:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Taylor Brandstetter, 2017-02-25 09:39:47]

deadbeef@webrtc.org changed reviewers:
+ tommi@webrtc.org

[commit-bot: I haz the power, 2017-02-25 09:45:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 09:45:20]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/19219)

[tommi, 2017-02-25 12:15:30]

lgtm!

https://codereview.webrtc.org/2719683002/diff/20001/webrtc/base/bind.h
File webrtc/base/bind.h (right):

https://codereview.webrtc.org/2719683002/diff/20001/webrtc/base/bind.h#newcod...
webrtc/base/bind.h:140: // Use sequence_generator to expand a MethodFunctor with
2 arguments to
can you add a reference to template_util.h here?  It took me a while to realize
what sequence_generator and sequence actually were until I looked at that
change, since the naming is in std style.
Something like this would be enough:

// Use sequence_generator (see template_util.h) to expand...

https://codereview.webrtc.org/2719683002/diff/20001/webrtc/pc/ortcfactory.cc
File webrtc/pc/ortcfactory.cc (right):

https://codereview.webrtc.org/2719683002/diff/20001/webrtc/pc/ortcfactory.cc#...
webrtc/pc/ortcfactory.cc:33: // just the function pointer.
Nice comment. I think we're so used to using Bind() without specifying the
template params that we can forget that it's actually possible.

[Taylor Brandstetter, 2017-02-25 18:42:05]

https://codereview.webrtc.org/2719683002/diff/20001/webrtc/base/bind.h
File webrtc/base/bind.h (right):

https://codereview.webrtc.org/2719683002/diff/20001/webrtc/base/bind.h#newcod...
webrtc/base/bind.h:140: // Use sequence_generator to expand a MethodFunctor with
2 arguments to
On 2017/02/25 12:15:29, tommi (webrtc) wrote:
> can you add a reference to template_util.h here?  It took me a while to
realize
> what sequence_generator and sequence actually were until I looked at that
> change, since the naming is in std style.
> Something like this would be enough:
> 
> // Use sequence_generator (see template_util.h) to expand...

Done.

[Taylor Brandstetter, 2017-02-25 18:42:11]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-02-25 18:42:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2719683002/#ps40001 (title:
"Mention where sequence_generator comes from in a comment.")

[commit-bot: I haz the power, 2017-02-25 18:42:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-25 19:21:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488048131357590,
"parent_rev": "4af9f962c3a79b97c4b2d85be4c30c9b77ef7a21", "commit_rev":
"08187d41ca45e4671e41856785590d2408c129b6"}

[commit-bot: I haz the power, 2017-02-25 19:21:21]

Description was changed from

==========
Rewrite rtc::Bind using variadic templates.

I'd like to make a change to rtc::Bind in another CL, and that will
be easier if there are fewer lines of code to modify.

BUG=None
==========

to

==========
Rewrite rtc::Bind using variadic templates.

I'd like to make a change to rtc::Bind in another CL, and that will
be easier if there are fewer lines of code to modify.

BUG=None

Review-Url: https://codereview.webrtc.org/2719683002
Cr-Commit-Position: refs/heads/master@{#16838}
Committed:
https://chromium.googlesource.com/external/webrtc/+/08187d41ca45e4671e4185678...
==========

[commit-bot: I haz the power, 2017-02-25 19:21:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/08187d41ca45e4671e4185678...