Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: webrtc/p2p/base/port.h

Issue 2719523002: RTCIceCandidatePairStats.[total/current]RoundTripTime collected. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/port.h
diff --git a/webrtc/p2p/base/port.h b/webrtc/p2p/base/port.h
index f6900210f4417e35da6384eaeba7b54433d43b46..36c88b1336d3c0d392c4d9dfe26e932264379500 100644
--- a/webrtc/p2p/base/port.h
+++ b/webrtc/p2p/base/port.h
@@ -27,6 +27,7 @@
#include "webrtc/base/asyncpacketsocket.h"
#include "webrtc/base/checks.h"
#include "webrtc/base/network.h"
+#include "webrtc/base/optional.h"
#include "webrtc/base/proxyinfo.h"
#include "webrtc/base/ratetracker.h"
#include "webrtc/base/sigslot.h"
@@ -699,6 +700,10 @@ class Connection : public CandidatePairInterface,
StunRequestManager requests_;
int rtt_;
int rtt_samples_ = 0;
+ // https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtriptime
+ rtc::Optional<uint64_t> total_round_trip_time_ms_;
Taylor Brandstetter 2017/02/25 01:31:29 Doesn't need to be rtc::Optional, since 0 is a sen
pthatcher1 2017/02/27 18:07:21 I wish spec were clear what is should be. But I a
hbos 2017/02/27 19:51:34 I agree 0 makes the most sense, done.
+ // https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentroundtriptime
+ rtc::Optional<uint32_t> current_round_trip_time_ms_;
int64_t last_ping_sent_; // last time we sent a ping to the other side
int64_t last_ping_received_; // last time we received a ping from the other
// side

Powered by Google App Engine
This is Rietveld 408576698