RTCIceCandidatePairStats.[total/current]RoundTripTime collected.

webrtc/p2p/base/port.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_P2P_BASE_PORT_H_
 #define WEBRTC_P2P_BASE_PORT_H_
 
 #include <map>
 #include <memory>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "webrtc/p2p/base/candidate.h"
 #include "webrtc/p2p/base/candidatepairinterface.h"
 #include "webrtc/p2p/base/jseptransport.h"
 #include "webrtc/p2p/base/packetsocketfactory.h"
 #include "webrtc/p2p/base/portinterface.h"
 #include "webrtc/p2p/base/stun.h"
 #include "webrtc/p2p/base/stunrequest.h"
 #include "webrtc/base/asyncpacketsocket.h"
 #include "webrtc/base/checks.h"
 #include "webrtc/base/network.h"
+#include "webrtc/base/optional.h"
 #include "webrtc/base/proxyinfo.h"
 #include "webrtc/base/ratetracker.h"
 #include "webrtc/base/sigslot.h"
 #include "webrtc/base/socketaddress.h"
 #include "webrtc/base/thread.h"
 
 namespace cricket {
 
 class Connection;
 class ConnectionRequest;
@@ skipping 652 matching lines @@
   uint32_t acked_nomination_ = 0;
   // Used by the controlled side to remember the nomination value received from
   // the controlling side. When the peer does not support ICE re-nomination,
   // its value will be 1 if the connection has been nominated.
   uint32_t remote_nomination_ = 0;
 
   IceMode remote_ice_mode_;
   StunRequestManager requests_;
   int rtt_;
   int rtt_samples_ = 0;
+  // https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtriptime
+  rtc::Optional<uint64_t> total_round_trip_time_ms_;

[Taylor Brandstetter, 2017/02/25 01:31:29]

Doesn't need to be rtc::Optional, since 0 is a sensible value for "no round
trips complete yet".

[pthatcher1, 2017/02/27 18:07:21]

I wish spec were clear what is should be.  But I agree that as currently
written, it seems like 0 is the right answer and not "nothing".

[hbos, 2017/02/27 19:51:34]

I agree 0 makes the most sense, done.

+  // https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentroundtriptime
+  rtc::Optional<uint32_t> current_round_trip_time_ms_;
   int64_t last_ping_sent_;      // last time we sent a ping to the other side
   int64_t last_ping_received_;  // last time we received a ping from the other
                                 // side
   int64_t last_data_received_;
   int64_t last_ping_response_received_;
   int64_t receiving_unchanged_since_ = 0;
   std::vector<SentPing> pings_since_last_response_;
 
   bool reported_;
   IceCandidatePairState state_;
@@ skipping 16 matching lines @@
            const rtc::PacketOptions& options) override;
   int GetError() override { return error_; }
 
  private:
   int error_ = 0;
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_P2P_BASE_PORT_H_