Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2718943004: Avoid overflow in NetEq's TimeStretch::SpeechDetection (Closed)

Created:
3 years, 9 months ago by hlundin-webrtc
Modified:
3 years, 9 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Avoid overflow in NetEq's TimeStretch::SpeechDetection BUG=chromium:675193 R=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2718943004 . Cr-Commit-Position: refs/heads/master@{#16902} Committed: https://chromium.googlesource.com/external/webrtc/+/b1629cf5d604363dd902b8ec2454ef279353c81f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/modules/audio_coding/neteq/time_stretch.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
hlundin-webrtc
kwiberg@, ptal.
3 years, 9 months ago (2017-02-27 13:18:49 UTC) #2
kwiberg-webrtc
lgtm. You'll pay a small penalty for using 64-bit arithmetic on 32-bit platforms, but since ...
3 years, 9 months ago (2017-02-28 10:02:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718943004/1
3 years, 9 months ago (2017-02-28 11:31:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/10591)
3 years, 9 months ago (2017-02-28 12:26:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718943004/1
3 years, 9 months ago (2017-02-28 12:36:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/10606)
3 years, 9 months ago (2017-02-28 13:33:05 UTC) #11
hlundin-webrtc
3 years, 9 months ago (2017-02-28 13:58:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1629cf5d604363dd902b8ec2454ef279353c81f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698