Replace NULL with nullptr or null in webrtc/base/.

Replace NULL with nullptr or null in webrtc/base/.

BUG=webrtc:7147
Review-Url: https://codereview.webrtc.org/2718663005
Cr-Commit-Position: refs/heads/master@{#16878}
Committed: https://chromium.googlesource.com/external/webrtc/+/37f5ecfd8f3337475872c9242221471784894f1c

[Taylor Brandstetter, 2017-02-26 01:44:51]

deadbeef@webrtc.org changed reviewers:
+ tommi@webrtc.org

[Taylor Brandstetter, 2017-02-26 01:44:52]

I already took a pass through this and fixed anything odd. The main thing was
just code snippets in comments, which should use "nullptr" instead of "null".

[tommi, 2017-02-26 11:41:10]

lgtm. Nicely done :)  great to fix a lot of formatting issues along the way.

https://codereview.webrtc.org/2718663005/diff/20001/webrtc/base/stringencode_...
File webrtc/base/stringencode_unittest.cc (right):

https://codereview.webrtc.org/2718663005/diff/20001/webrtc/base/stringencode_...
webrtc/base/stringencode_unittest.cc:24: {"a    ", 5, 1, 'a'},
In these cases we could use

// clang-format off
<code>
// clang-format on

If you think it's worth it, feel free to do a follow up CL and tbr it. (or not,
it's fine as is)

[tommi, 2017-02-26 11:41:16]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2017-02-26 11:41:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-26 11:46:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 11:46:49]

Try jobs failed on following builders:
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/23128)

[tommi, 2017-02-26 17:19:49]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 17:19:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-02-26 17:20:10]

of course windows code had to cause problems ;)

https://codereview.webrtc.org/2718663005/diff/20001/webrtc/base/win32socketse...
File webrtc/base/win32socketserver.cc (right):

https://codereview.webrtc.org/2718663005/diff/20001/webrtc/base/win32socketse...
webrtc/base/win32socketserver.cc:246: socket_ = ::WSASocket(family, type, proto,
nullptr, nullptr, 0);
need to change this to:

WSASocket(family, type, proto, nullptr, 0, 0);

[tommi, 2017-02-26 17:23:45]

https://codereview.webrtc.org/2718663005/diff/20001/webrtc/base/win32window.cc
File webrtc/base/win32window.cc (right):

https://codereview.webrtc.org/2718663005/diff/20001/webrtc/base/win32window.c...
webrtc/base/win32window.cc:110: ::SetWindowLongPtr(hwnd, GWLP_USERDATA,
nullptr);
the name SetWindowLongPtr() is misleading unfortunately.  The last argument is
LONG_PTR and not actually a pointer, so you need to use 0 here.

[commit-bot: I haz the power, 2017-02-26 17:25:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 17:25:46]

Dry run: Try jobs failed on following builders:
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/23140)

[Taylor Brandstetter, 2017-02-27 21:40:15]

https://codereview.webrtc.org/2718663005/diff/20001/webrtc/base/stringencode_...
File webrtc/base/stringencode_unittest.cc (right):

https://codereview.webrtc.org/2718663005/diff/20001/webrtc/base/stringencode_...
webrtc/base/stringencode_unittest.cc:24: {"a    ", 5, 1, 'a'},
On 2017/02/26 11:41:10, tommi (webrtc) wrote:
> In these cases we could use
> 
> // clang-format off
> <code>
> // clang-format on
> 
> If you think it's worth it, feel free to do a follow up CL and tbr it. (or
not,
> it's fine as is)

Good catch, done.

https://codereview.webrtc.org/2718663005/diff/20001/webrtc/base/win32socketse...
File webrtc/base/win32socketserver.cc (right):

https://codereview.webrtc.org/2718663005/diff/20001/webrtc/base/win32socketse...
webrtc/base/win32socketserver.cc:246: socket_ = ::WSASocket(family, type, proto,
nullptr, nullptr, 0);
On 2017/02/26 17:20:10, tommi (webrtc) wrote:
> need to change this to:
> 
> WSASocket(family, type, proto, nullptr, 0, 0);

Interesting, here we were using NULL with something that wasn't a pointer type.

[Taylor Brandstetter, 2017-02-27 21:40:20]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-02-27 21:40:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2718663005/#ps40001 (title:
"Fixing Windows and formatting issues.")

[commit-bot: I haz the power, 2017-02-27 21:40:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-27 22:06:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488231620823880,
"parent_rev": "c5da4785f346dc32e6219fa689d6cd619e55f114", "commit_rev":
"37f5ecfd8f3337475872c9242221471784894f1c"}

[commit-bot: I haz the power, 2017-02-27 22:06:47]

Description was changed from

==========
Replace NULL with nullptr or null in webrtc/base/.

BUG=webrtc:7147
==========

to

==========
Replace NULL with nullptr or null in webrtc/base/.

BUG=webrtc:7147

Review-Url: https://codereview.webrtc.org/2718663005
Cr-Commit-Position: refs/heads/master@{#16878}
Committed:
https://chromium.googlesource.com/external/webrtc/+/37f5ecfd8f3337475872c9242...
==========

[commit-bot: I haz the power, 2017-02-27 22:06:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/37f5ecfd8f3337475872c9242...