[Sync] Adjust types to configure during shutdown

[Sync] Adjust types to configure during shutdown

When preparing request to server we need to make sure there are update handlers
registered for all types to download. It is possible that configuration cycle
is scheduled with set of types that are later unregistered from
ModelTypeRegistry as part of shutdown. When configuration cycle gets to run
it DCHECKs on types that were requested but later unregistered.

The solution is to detect shutdown condition and adjust types to download.

BUG=683216
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2718533003
Cr-Commit-Position: refs/heads/master@{#452932}
Committed: https://chromium.googlesource.com/chromium/src/+/2010aad1ee6e6b1edfff8e726dbfbea20c2a6ce4

[pavely, 2017-02-24 02:23:48]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 02:24:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 03:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 03:23:22]

Dry run: This issue passed the CQ dry run.

[skym, 2017-02-24 17:04:25]

lgtm

https://codereview.chromium.org/2718533003/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/syncer.cc (right):

https://codereview.chromium.org/2718533003/diff/1/components/sync/engine_impl...
components/sync/engine_impl/syncer.cc:90: if
(cancelation_signal_->IsSignalled())
Would be good to have a unit test for this as well.

[pavely, 2017-02-24 18:54:13]

The CQ bit was checked by pavely@chromium.org

[pavely, 2017-02-24 18:54:13]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org
Link to the patchset: https://codereview.chromium.org/2718533003/#ps20001
(title: "Add syncer unittest")

[pavely, 2017-02-24 18:54:32]

https://codereview.chromium.org/2718533003/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/syncer.cc (right):

https://codereview.chromium.org/2718533003/diff/1/components/sync/engine_impl...
components/sync/engine_impl/syncer.cc:90: if
(cancelation_signal_->IsSignalled())
On 2017/02/24 17:04:25, skym wrote:
> Would be good to have a unit test for this as well.

Done.

[commit-bot: I haz the power, 2017-02-24 18:54:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 19:11:30]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pavely, 2017-02-24 19:20:18]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2017-02-24 19:21:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 21:35:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487964018846110,
"parent_rev": "2869150d31cb0529f16f7d571ef650d1d2bebd99", "commit_rev":
"2010aad1ee6e6b1edfff8e726dbfbea20c2a6ce4"}

[commit-bot: I haz the power, 2017-02-24 21:36:35]

Description was changed from

==========
[Sync] Adjust types to configure during shutdown

When preparing request to server we need to make sure there are update handlers
registered for all types to download. It is possible that configuration cycle
is scheduled with set of types that are later unregistered from
ModelTypeRegistry as part of shutdown. When configuration cycle gets to run
it DCHECKs on types that were requested but later unregistered.

The solution is to detect shutdown condition and adjust types to download.

BUG=683216
R=skym@chromium.org
==========

to

==========
[Sync] Adjust types to configure during shutdown

When preparing request to server we need to make sure there are update handlers
registered for all types to download. It is possible that configuration cycle
is scheduled with set of types that are later unregistered from
ModelTypeRegistry as part of shutdown. When configuration cycle gets to run
it DCHECKs on types that were requested but later unregistered.

The solution is to detect shutdown condition and adjust types to download.

BUG=683216
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2718533003
Cr-Commit-Position: refs/heads/master@{#452932}
Committed:
https://chromium.googlesource.com/chromium/src/+/2010aad1ee6e6b1edfff8e726dbf...
==========

[commit-bot: I haz the power, 2017-02-24 21:36:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2010aad1ee6e6b1edfff8e726dbf...