Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 2718363002: Reland Move fake_audio_device to its own target. (Closed)

Created:
3 years, 9 months ago by perkj_webrtc
Modified:
3 years, 9 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland Move fake_audio_device to its own target. Patchset 1 is patchset #5 id:80001 of https://codereview.webrtc.org/2717983003/ Patchset 2 fix call_perf_test dep on fake_audio_device. This reverts commit 985371bda999c6db51286586c5850d2ff58f3511. Original cl description: Move fake_audio_device to its own target. The purpose is to make it usefull for test targets that does not need or can use test_common. For some reason this also triggered override issues in rtp module tests that are fixed in the same cl. BUG=none TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2718363002 Cr-Commit-Position: refs/heads/master@{#16922} Committed: https://chromium.googlesource.com/external/webrtc/+/16ccfdf45746d034a5692bf707d03f6746beb240

Patch Set 1 #

Patch Set 2 : Fix call_perf_test dependency on fake_audio_device. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M webrtc/call/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/BUILD.gn View 3 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
perkj_webrtc
3 years, 9 months ago (2017-02-28 11:39:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718363002/20001
3 years, 9 months ago (2017-02-28 11:40:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/10592)
3 years, 9 months ago (2017-02-28 12:29:04 UTC) #7
kjellander_webrtc
lgtm I'll land this for you, the linux_ubsan_vptr trybot errors seems to have hit other ...
3 years, 9 months ago (2017-02-28 22:39:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718363002/20001
3 years, 9 months ago (2017-02-28 22:39:10 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 22:41:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/16ccfdf45746d034a5692bf70...

Powered by Google App Engine
This is Rietveld 408576698