Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2718353003: Fix reporting QP in FFmpeg H264 encoder. (Closed)

Created:
3 years, 9 months ago by sakal
Modified:
3 years, 9 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman, kthelgason
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix reporting QP in FFmpeg H264 encoder. The QP was previously written after calling OnEncodedImage. This was a bug. BUG=webrtc:6541 Review-Url: https://codereview.webrtc.org/2718353003 Cr-Commit-Position: refs/heads/master@{#16911} Committed: https://chromium.googlesource.com/external/webrtc/+/a2508c1e0fac53c0ddd56836efb98dc85b3eb845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sakal
PTAL I discovered this bug in the encoder when writing a test for my other ...
3 years, 9 months ago (2017-02-28 14:54:16 UTC) #3
sprang_webrtc
doh! lgtm
3 years, 9 months ago (2017-02-28 15:17:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718353003/1
3 years, 9 months ago (2017-02-28 15:18:38 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 15:57:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a2508c1e0fac53c0ddd56836e...

Powered by Google App Engine
This is Rietveld 408576698