Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2718343002: Make FakeNetworkPipe not busy loop any more. (Closed)

Created:
3 years, 9 months ago by philipel
Modified:
3 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make FakeNetworkPipe not busy loop any more. BUG=webrtc:7259, webrtc:7255 Review-Url: https://codereview.webrtc.org/2718343002 Cr-Commit-Position: refs/heads/master@{#16896} Committed: https://chromium.googlesource.com/external/webrtc/+/50235b77d06965d75f0adaf874d8cf04618edf63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M webrtc/test/fake_network_pipe.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
philipel
PTAL
3 years, 9 months ago (2017-02-28 10:15:35 UTC) #7
tommi
lgtm. thanks - that looks like a saner approach than what I did :)
3 years, 9 months ago (2017-02-28 10:16:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718343002/1
3 years, 9 months ago (2017-02-28 10:17:25 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 10:19:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/50235b77d06965d75f0adaf87...

Powered by Google App Engine
This is Rietveld 408576698