webrtc/call/call_perf_tests.cc - Issue 2717973005: Test field trial group with startswith rather than equals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/call/call_perf_tests.cc

Issue 2717973005: Test field trial group with startswith rather than equals. (Closed)

Patch Set: const char*, two more IsEnabled Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/call/call_perf_tests.cc

diff --git a/webrtc/call/call_perf_tests.cc b/webrtc/call/call_perf_tests.cc

index 570b19b4ce61ea7945b3c9154bcf4922576fdba1..a510483690e8aadb7e6c646ba365c4b23164f4f1 100644

--- a/webrtc/call/call_perf_tests.cc

+++ b/webrtc/call/call_perf_tests.cc

@@ -290,7 +290,7 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec,

observer.PrintResults();

// In quick test synchronization may not be achieved in time.

- if (field_trial::FindFullName("WebRTC-QuickPerfTest") != "Enabled") {

+ if (field_trial::IsEnabled("WebRTC-QuickPerfTest")) {

danilchap 2017/03/01 12:07:15 should this be negation?

EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.AVSyncOffsetInMs"));

}