Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: webrtc/call/call_perf_tests.cc

Issue 2717973005: Test field trial group with startswith rather than equals. (Closed)
Patch Set: const char*, two more IsEnabled Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 voe_base->DeleteChannel(recv_channel_id); 283 voe_base->DeleteChannel(recv_channel_id);
284 voe_base->Release(); 284 voe_base->Release();
285 285
286 DestroyCalls(); 286 DestroyCalls();
287 287
288 VoiceEngine::Delete(voice_engine); 288 VoiceEngine::Delete(voice_engine);
289 289
290 observer.PrintResults(); 290 observer.PrintResults();
291 291
292 // In quick test synchronization may not be achieved in time. 292 // In quick test synchronization may not be achieved in time.
293 if (field_trial::FindFullName("WebRTC-QuickPerfTest") != "Enabled") { 293 if (field_trial::IsEnabled("WebRTC-QuickPerfTest")) {
danilchap 2017/03/01 12:07:15 should this be negation?
294 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.AVSyncOffsetInMs")); 294 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.AVSyncOffsetInMs"));
295 } 295 }
296 } 296 }
297 297
298 TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithVideoNtpDrift) { 298 TEST_F(CallPerfTest, PlaysOutAudioAndVideoInSyncWithVideoNtpDrift) {
299 TestAudioVideoSync(FecMode::kOff, CreateOrder::kAudioFirst, 299 TestAudioVideoSync(FecMode::kOff, CreateOrder::kAudioFirst,
300 DriftingClock::PercentsFaster(10.0f), 300 DriftingClock::PercentsFaster(10.0f),
301 DriftingClock::kNoDrift, DriftingClock::kNoDrift); 301 DriftingClock::kNoDrift, DriftingClock::kNoDrift);
302 } 302 }
303 303
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 uint32_t last_set_bitrate_kbps_; 736 uint32_t last_set_bitrate_kbps_;
737 VideoSendStream* send_stream_; 737 VideoSendStream* send_stream_;
738 test::FrameGeneratorCapturer* frame_generator_; 738 test::FrameGeneratorCapturer* frame_generator_;
739 VideoEncoderConfig encoder_config_; 739 VideoEncoderConfig encoder_config_;
740 } test; 740 } test;
741 741
742 RunBaseTest(&test); 742 RunBaseTest(&test);
743 } 743 }
744 744
745 } // namespace webrtc 745 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/media/engine/internalencoderfactory.cc » ('j') | webrtc/modules/remote_bitrate_estimator/test/bwe_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698