Making candidate pool size behave as decided in JSEP.

Making candidate pool size behave as decided in JSEP.

To simplify things, the candidate pool is only used in the first
offer/answer.

After setting a local description, the size is frozen, and changing ICE
servers won't refresh the pool.

After setting an answer, the pooled candidates are discarded.

BUG=webrtc:5180
Review-Url: https://codereview.webrtc.org/2717893003
Cr-Commit-Position: refs/heads/master@{#17178}
Committed: https://chromium.googlesource.com/external/webrtc/+/42a426372878850160e1e627478335a880cebd9f

[Taylor Brandstetter, 2017-02-26 04:39:55]

The CQ bit was checked by deadbeef@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 04:39:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-26 04:50:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 04:50:47]

Dry run: Try jobs failed on following builders:
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/23252)

[Taylor Brandstetter, 2017-02-26 04:54:22]

The CQ bit was checked by deadbeef@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 04:54:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-26 05:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 05:29:34]

Dry run: Try jobs failed on following builders:
  linux_memcheck on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/5687)

[Taylor Brandstetter, 2017-03-07 20:26:50]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2017-03-07 20:26:50]

PTAL

[pthatcher1, 2017-03-09 00:28:15]

lgtm

https://codereview.webrtc.org/2717893003/diff/40001/webrtc/p2p/base/portalloc...
File webrtc/p2p/base/portallocator.h (right):

https://codereview.webrtc.org/2717893003/diff/40001/webrtc/p2p/base/portalloc...
webrtc/p2p/base/portallocator.h:379: void DiscardPooledSessions();
DiscardCandidatePool?

To be consistent with FreezeCandidatePool.

[Taylor Brandstetter, 2017-03-09 14:59:03]

https://codereview.webrtc.org/2717893003/diff/40001/webrtc/p2p/base/portalloc...
File webrtc/p2p/base/portallocator.h (right):

https://codereview.webrtc.org/2717893003/diff/40001/webrtc/p2p/base/portalloc...
webrtc/p2p/base/portallocator.h:379: void DiscardPooledSessions();
On 2017/03/09 00:28:15, pthatcher1 wrote:
> DiscardCandidatePool?
> 
> To be consistent with FreezeCandidatePool.

Done

[Taylor Brandstetter, 2017-03-10 22:41:43]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-03-10 22:41:43]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2717893003/#ps80001 (title:
"Merge with master")

[commit-bot: I haz the power, 2017-03-10 22:41:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-10 23:18:01]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489185703333820,
"parent_rev": "d62cb220f2f36a2db54d0f2c1382e0c509220e54", "commit_rev":
"42a426372878850160e1e627478335a880cebd9f"}

[commit-bot: I haz the power, 2017-03-10 23:18:04]

Description was changed from

==========
Making candidate pool size behave as decided in JSEP.

To simplify things, the candidate pool is only used in the first
offer/answer.

After setting a local description, the size is frozen, and changing ICE
servers won't refresh the pool.

After setting an answer, the pooled candidates are discarded.

BUG=webrtc:5180
==========

to

==========
Making candidate pool size behave as decided in JSEP.

To simplify things, the candidate pool is only used in the first
offer/answer.

After setting a local description, the size is frozen, and changing ICE
servers won't refresh the pool.

After setting an answer, the pooled candidates are discarded.

BUG=webrtc:5180

Review-Url: https://codereview.webrtc.org/2717893003
Cr-Commit-Position: refs/heads/master@{#17178}
Committed:
https://chromium.googlesource.com/external/webrtc/+/42a426372878850160e1e6274...
==========

[commit-bot: I haz the power, 2017-03-10 23:18:05]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/42a426372878850160e1e6274...