Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2717683002: Adding placeholder for low bandwidth audio test (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
ossu, oprypin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tlegrand-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding placeholder for low bandwidth audio test This will allow the trybots to be updated to start running this new test executable, so that they can be used when landing this CL which will replace the dummy test with real code: https://codereview.webrtc.org/2694203002 Most likely, the trybots will just run the test binary while the perf bots will run a Python wrapper script that takes care of the post-processing to calculate audio quality using PESQ. BUG=webrtc:7229 NOTRY=True Review-Url: https://codereview.webrtc.org/2717683002 Cr-Commit-Position: refs/heads/master@{#17063} Committed: https://chromium.googlesource.com/external/webrtc/+/8f8d1a06b97d0cbb9cae90afcddb93f5de2450a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
M webrtc/audio/BUILD.gn View 2 chunks +20 lines, -0 lines 0 comments Download
A webrtc/audio/test/low_bandwidth_audio_test.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A webrtc/audio/test/low_bandwidth_audio_test.py View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
kjellander_webrtc
I think this is the location we want this, but it's certainly possible to have ...
3 years, 10 months ago (2017-02-24 12:41:57 UTC) #3
oprypin_webrtc
Thank you LGTM
3 years, 10 months ago (2017-02-24 12:57:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2717683002/1
3 years, 9 months ago (2017-02-26 00:20:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14081)
3 years, 9 months ago (2017-02-26 00:25:29 UTC) #8
kjellander_webrtc
Ah, need ossu@ as well.
3 years, 9 months ago (2017-02-26 03:41:19 UTC) #9
kjellander_webrtc
Friendly ping!
3 years, 9 months ago (2017-02-28 05:18:07 UTC) #10
ossu
Sorry, was travelling. LGTM.
3 years, 9 months ago (2017-03-02 00:17:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2717683002/1
3 years, 9 months ago (2017-03-06 11:59:04 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 12:01:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8f8d1a06b97d0cbb9cae90afc...

Powered by Google App Engine
This is Rietveld 408576698